Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pytorch_lighting imports into lightning.pytorch imports #113

Closed
wants to merge 1 commit into from
Closed

Conversation

marios1861
Copy link

  • Bug fix

Description

Fixes #112

Testing

Isolated change, working as intended.

@XuehaiPan
Copy link
Owner

Hi @marios1861 thanks for the pull request. Following the discussion in issue #112, I would rather keep the support for pytorch-lightning. Because pytorch-lightning and lightning are different packages on PyPI, and they are not compatible with each other (see your issue). I populate the implementation for lightning based on lighting.pytorch.callbacks.Callback in PR #114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Pytorch lightning callback
2 participants