Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the shoot-flux extension uses latest tag but it does not exist #1840

Closed

Conversation

Lappihuan
Copy link

@berendt berendt requested a review from lotharbach December 10, 2024 12:34
@lotharbach
Copy link
Contributor

The version for this extension is set and updated here:

The helmcharts folder is just an "import" of upstream charts and we do not modify it directly. So even if you tried this change and it did fix your problem it is still not the right way to fix the problem in yake. If this is even related to a problem that you experience in your setup, I'd need more information to help you fix it.

@Lappihuan
Copy link
Author

Lappihuan commented Dec 10, 2024

Ok, that makes sense.
Yes we actually have to set the tag in extension-values because it tries to pull latest otherwise:

    shoot-flux:
      enabled: true
      globallyEnabled: true
      values:
        image:
          tag: v0.12.0

So the right thing to do would be to change it here in upstream?
https://github.com/stackitcloud/gardener-extension-shoot-flux/blob/504fad5002d5f81f401d0f145b376e1d18549b26/deploy/extension/base/controller-registration.yaml#L10

or maybe even this one:
https://github.com/stackitcloud/gardener-extension-shoot-flux/blob/95940944322374f2c3e400728b08998240881636/charts/gardener-extension-shoot-flux/values.yaml#L8

@Lappihuan Lappihuan closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants