Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webterminal helm install #1933

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix webterminal helm install #1933

merged 2 commits into from
Feb 10, 2025

Conversation

Lappihuan
Copy link
Contributor

Fixes #1908

@Lappihuan Lappihuan marked this pull request as ready for review February 10, 2025 08:13
rhizoet
rhizoet approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@rhizoet rhizoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lotharbach
lotharbach requested changes Feb 10, 2025
View reviewed changes
configuration/configuration/templates/webterminal.yaml Outdated Show resolved Hide resolved
gardener/certificates/templates/cert-manager-ca.yaml Outdated Show resolved Hide resolved
gardener/webterminal.yaml Show resolved Hide resolved
@Lappihuan Lappihuan requested a review from lotharbach February 10, 2025 14:50
@lotharbach lotharbach merged commit 5e1e2ca into YAKEcloud:main Feb 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotharbach lotharbach lotharbach approved these changes

@rhizoet rhizoet rhizoet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix upstream webterminal chart installation
3 participants
@Lappihuan @lotharbach @rhizoet