Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: push notification #73

Merged
merged 5 commits into from
Feb 9, 2024
Merged

feat: push notification #73

merged 5 commits into from
Feb 9, 2024

Conversation

Seokyeong237
Copy link
Member

@Seokyeong237 Seokyeong237 commented Feb 9, 2024 •
edited
Loading

πŸ“ Summary

Implemeted a push notification

πŸ‘©β€πŸ’» Contents

Case 1. Passenger - When a form is accepted
Case 2. Passenger - When a form is rejected
Case 3. Driver - When a request is received

πŸ“ Review Note

I made an Alarm Service and wrote a sendNotification inside. And I imported an AlarmService in a FormService.
Do you think it's better to just make a sendNotification function in FormService?

πŸ“£ Related Issue

@Seokyeong237 Seokyeong237 self-assigned this Feb 9, 2024
Park-Young-Hun
Park-Young-Hun approved these changes Feb 9, 2024
View reviewed changes
src/main/java/com/fullcar/carpool/application/Alarm/AlarmService.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ €λ²ˆ 이메일 인증과 λ™μΌν•˜κ²Œ ν‘Έμ‹œμ•Œλ¦Ό λ˜ν•œ μ™ΈλΆ€μ‹œμŠ€ν…œμ„ 톡해 λ³΄λ‚΄λŠ” 것이기 λ•Œλ¬Έμ— λ„λ©”μΈμ„œλΉ„μŠ€μ— μΈν„°νŽ˜μ΄μŠ€λ₯Ό μ •μ˜ν•˜κ³  infra μ˜μ—­μ—μ„œ PushMessageClientκ³Ό 같은 객체λ₯Ό λ§Œλ“€μ–΄ sendNotification() ν•¨μˆ˜λ₯Ό κ΅¬ν˜„ν•˜λŠ” 것도 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ°˜μ˜μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€!

src/main/java/com/fullcar/carpool/application/form/FormService.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν‘Έμ‹œμ•Œλ¦Όμ€ μ™ΈλΆ€μ‹œμŠ€ν…œμ„ 톡해 λ³΄λ‚΄λŠ” 것이기 λ•Œλ¬Έμ— FormService와 κ²°ν•©λœ ν˜•νƒœλ‘œ κ°œλ°œλœλ‹€λ©΄ μ™ΈλΆ€μ‹œμŠ€ν…œμ— μ˜μ‘΄ν•˜κ²Œ 될 κ°€λŠ₯성이 μžˆλ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€! λ”°λΌμ„œ Spring Eventλ₯Ό ν™œμš©ν•˜μ—¬ 결합도λ₯Ό λŠμŠ¨ν•˜κ²Œ ν•˜λŠ” λ°©μ•ˆλ„ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToDo둜 이슈 νŒŒλ†“μ„κ²Œμš”!

@Seokyeong237 Seokyeong237 merged commit ad61876 into develop Feb 9, 2024
1 check passed
@Seokyeong237 Seokyeong237 deleted the feat/ISSUE-72 branch February 13, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Park-Young-Hun Park-Young-Hun Park-Young-Hun approved these changes

Assignees

@Seokyeong237 Seokyeong237

Labels
feat πŸ²μ„œκ²½πŸ²
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: push notification
2 participants
@Seokyeong237 @Park-Young-Hun