Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qa/75 78 LoginScreen 실제 투표 데이터로 교체, 로고 위치 조정 #155

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Qa/75 78 LoginScreen 실제 투표 데이터로 교체, 로고 위치 조정 #155

merged 4 commits into from
Feb 16, 2024

Conversation

yangsooplus
Copy link
Member

@yangsooplus yangsooplus commented Feb 16, 2024 •
edited
Loading

🌱 Key changes

  • 로그인 화면의 하드코딩 가짜 데이터를 찐퉁으로 교체했습니다.
  • 동률인 항목이 있을 때에는 List 순서가 앞선 데이터를 보여줍니다.
  • 네트워크 미연결 등 오류 발생 시에는 ?로 가려진 데이터를 보여줍니다. (2번째 영상 참고)
    • 원 그래프 기본값: 85%
  • QA-78: 로고 위치 재조정했습니다.

📸 스크린샷

  • 일반적인 동작
default.mp4
  • 네트워크 미연결 등 오류 발생 시
default.mp4

@yangsooplus yangsooplus added the QA label Feb 16, 2024
@yangsooplus yangsooplus self-assigned this Feb 16, 2024
@yangsooplus yangsooplus marked this pull request as ready for review February 16, 2024 07:14
@yangsooplus
Copy link
Member Author

Draft로 올려도 알림 가나요? 어케보셨지

@yangsooplus yangsooplus merged commit 94894b5 into develop Feb 16, 2024
1 check passed
@yangsooplus yangsooplus deleted the QA/75-oboard-vote-data branch February 16, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinukeu jinukeu jinukeu approved these changes

@syb8200 syb8200 Awaiting requested review from syb8200

Assignees

@yangsooplus yangsooplus

Labels
QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangsooplus @jinukeu