flake: use nightly rust-analyzer and add rust-src component #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodiboo
commented
Oct 15, 2024
| @@ -22,6 +22,130 @@ | |||
| rust-overlay, | |||
| }: | |||
| let | |||
| niri-package = | |||
| { | |||
| lib, | |||
There was a problem hiding this comment.
it's easy to miss in the diff but when moving this package declaration up here, i've also separately added the lib parameter so that comes from pkgs.callPackage instead of our outermost inherit (nixpkgs) lib;. this is the only change to the package declaration; the actual contents are identical to what they previously were
getchoo
approved these changes
Oct 15, 2024
this also improves the application of overlays to be more uniform; what was previously done was just Wrong
getchoo
approved these changes
Oct 15, 2024
|
Thanks |
I think I just might. It'll be nice to have more than one pair of eyes actively overlooking the code. |
FluxTape
pushed a commit
to FluxTape/niri
that referenced
this pull request
Oct 15, 2024
this also improves the application of overlays to be more uniform; what was previously done was just Wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also improves the application of overlays to be more uniform, in particular this like applying the overlay was just weird and basically wrong (that's not how overlays work)
there's also some subtlety with using
selectLatestNightlyWith. from rust-overlay's README:and uhh... i think
packages.${system}.rust-nightlymaps torust-bin.nightly.latest? so we were using the one that the README says not to use? the code is slightly hard to read. Either way, this subtlety wasn't causing any issues previously, but is fixed now to prevent it from causing any issues in the future as well.the main benefit is that we're now using
rust-analyzeralso fromrust-overlay, as well as including therust-srccomponent which is required forrust-analyzerto actually be useful. this is a required change because rust-analyzer is basically useless in the devshell since #687 because uhh Nobody Thought To Test It. the other stuff in this PR is mostly just refactoring.cc @getchoo you touched this last and idk if you want to review it or anything, but feel free to leave comments. or don't, i don't know how much you want to be involved in the future