Yamraaj (Sourcery refactored) #9
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| newname = match.group(1) | ||
| newname = match[1] |
There was a problem hiding this comment.
Function MyLogger.debug refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects (
use-getitem-for-re-match-groups)
| if not self.is_playlist: | ||
| self.opts['outtmpl'] = f"{path}/{self.name}" | ||
| else: | ||
| self.opts['outtmpl'] = f"{path}/{self.name}/%(title)s.%(ext)s" | ||
| self.opts['outtmpl'] = ( | ||
| f"{path}/{self.name}/%(title)s.%(ext)s" | ||
| if self.is_playlist | ||
| else f"{path}/{self.name}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function YoutubeDLHelper.add_download refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
| return res.group(5) | ||
| return res[5] |
There was a problem hiding this comment.
Function GoogleDriveHelper.getIdFromUrl refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects (
use-getitem-for-re-match-groups)
| while response is None: | ||
| if self.is_cancelled: | ||
| break | ||
| while response is None and not self.is_cancelled: |
There was a problem hiding this comment.
Function GoogleDriveHelper.upload_file refactored with the following changes:
- Move a guard clause in a while statement's body into its test (
while-guard-to-condition)
| LOGGER.info("Uploading File: " + file_path) | ||
| LOGGER.info(f"Uploading File: {file_path}") |
There was a problem hiding this comment.
Function GoogleDriveHelper.upload refactored with the following changes:
- Use f-string instead of string concatenation [×3] (
use-fstring-for-concatenation)
| path += folder_name + '/' | ||
| path += f'{folder_name}/' |
There was a problem hiding this comment.
Function GoogleDriveHelper.download_folder refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| fh = io.FileIO('{}{}'.format(path, filename), 'wb') | ||
| fh = io.FileIO(f'{path}{filename}', 'wb') |
There was a problem hiding this comment.
Function GoogleDriveHelper.download_file refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| path = m_path + ".zip" | ||
| path = f"{m_path}.zip" |
There was a problem hiding this comment.
Function MirrorListener.onDownloadComplete refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| f' \n' \ | ||
| f'🔥 𝙔𝙖𝙢𝙧𝙖𝙖𝙟 𝙈𝙞𝙧𝙧𝙤𝙧 𝙕𝙤𝙣𝙀\n' \ | ||
| f' \n' \ | ||
| f'🔥 𝙂𝙧𝙤𝙪𝙥 : @mirrorclouds\n' | ||
| f' \n' \ | ||
| f'🔥 𝙔𝙖𝙢𝙧𝙖𝙖𝙟 𝙈𝙞𝙧𝙧𝙤𝙧 𝙕𝙤𝙣𝙀\n' \ | ||
| f' \n' \ | ||
| f'🔥 𝙂𝙧𝙤𝙪𝙥 : @mirrorclouds\n' |
There was a problem hiding this comment.
Found the following improvement in Function MirrorListener.onUploadComplete:
| file = None | ||
| media_array = [reply_to.document, reply_to.video, reply_to.audio] | ||
| for i in media_array: | ||
| if i is not None: | ||
| file = i | ||
| break | ||
| file = next((i for i in media_array if i is not None), None) |
There was a problem hiding this comment.
Function _mirror refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Use the built-in function
nextinstead of a for-loop (use-next)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.21%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #8 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
Yamraajbranch, then run:Help us improve this pull request!