Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troyfeng116/tests #45

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

troyfeng116/tests #45

wants to merge 14 commits into from

Conversation

troyfeng116
Copy link
Collaborator

No description provided.

@niansong1996
Copy link
Contributor

@troyfeng116 LMK if you want my input on anything

@niansong1996
Copy link
Contributor

For integration test, one suggestion is that instead of doing what I did in tests/test_inference_pipeline.py, you should follow this doc and run it with Lightning API instead

@troyfeng116
Copy link
Collaborator Author

For integration test, one suggestion is that instead of doing what I did in tests/test_inference_pipeline.py, you should follow this doc and run it with Lightning API instead

Got it, currently working on models (something similar to what I did for datasets if you have time to take a look at that).

Would using Lightning API just be to avoid using os.system?

@niansong1996
Copy link
Contributor

Would using Lightning API just be to avoid using os.system?

Yes, but it seems like this function is not added for the version of the lightning we are using (1.7.4). So let's stall this.

@niansong1996
Copy link
Contributor

But I found another issue: I was trying to use GPUs for the tests but got error like this you've requested GPU [0,1] but only got [0]. I suspect that when you start the runner, there is some env var that sets CUDA_VISIBLE_DEVICES=0 somewhere. Can you check this out?

@troyfeng116
Copy link
Collaborator Author

But I found another issue: I was trying to use GPUs for the tests but got error like this you've requested GPU [0,1] but only got [0]. I suspect that when you start the runner, there is some env var that sets CUDA_VISIBLE_DEVICES=0 somewhere. Can you check this out?

Should have just fixed, left an env vars from SummerTime I think

@niansong1996
Copy link
Contributor

I just merged #40 into main, so please merge from main and fix the conflicts. But definitely feel free to ping me if you need me on anything.

@troyfeng116
Copy link
Collaborator Author

@niansong1996 Running into some problem with spider_reader, seems like example_to_demonstration_sql was deprecated so promptify_function function pointer can't be resolved?

@niansong1996
Copy link
Contributor

Ignore the non-few-shot datasets for now and add an issue as a TODO instead.

@troyfeng116 troyfeng116 requested a review from niansong1996 May 1, 2023 17:44
@troyfeng116
Copy link
Collaborator Author

@niansong1996 done expanding all tests, takes about 9-10 minutes to run at the moment. Let me know if it look ok for now, ready to merge anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants