Dockerize korotagger and automate DB Initialization #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarn
requested changes
Aug 3, 2024
Revert https to git
replace image with build directive, remove unecessary cpu and memory limits and leave it up to user to add them back
remove check for my own inserted "config.first_time_run", instead use "member.required_roles" which is the last created table on the third SQL script at migrations
comment out image directive, encourage building instead for the latest builds from repo directly. add double quotes on example postgres password to encourage properly quoting password
Yarn
requested changes
Sep 2, 2024
| wait_for_postgres | ||
|
|
||
| # Check if it is the first time run | ||
| if check_first_time_run; then |
There was a problem hiding this comment.
should remove check_first_time_run. korotagger migrate will only apply new migrations already and we probably want new migrations applied after updates
|
sorry for the slow response, i think there's just the one thing left to fix. it probably makes sense to leave the 100MB memory limit for korotagger. korotagger usually only uses around 12MB at most. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.