Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added PDAL loading/saving with dimension retention #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nvandamme
Copy link

#4

@Yarroudh
Copy link
Owner

Yarroudh commented Jul 4, 2023

Hello @nvandamme,
Thanks for the enhancements you added, this is very useful. I'll review your pull request very soon.

@Yarroudh Yarroudh added the enhancement New feature or request label Jul 4, 2023
@Yarroudh
Copy link
Owner

Hello @nvandamme, I would like to know if you have ran any tests with the different formats you added?

@nvandamme
Copy link
Author

nvandamme commented Jul 10, 2023 via email

@Yarroudh
Copy link
Owner

The package was updated to a new version. I did not have the time to review your PR, especially that you did not run any tests with other formats. If you want always to contribute, you can adapt your changes to the new version of segment-lidar to resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants