Dynamic Window Size #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erying on merging and need to send
…ow doesn't change yet)
…ra packets, resulting in the sending stalling
Packets can arrive out of order or not be sent at all (due to recent changes and "packet stuffing") and this results in false packet loss increase with the recent changes. It could also result in the packets being "double counted" for packet loss, due to another packet increment being when the packet wait time expires
|
I'm merging this in in the current state. This doesn't have the window size adjusting automatically - this will be handled through a subsequent PR. We've tested these changes a fair bit and it seems to not break anything. The "packet stuffing" also helps queuing a fair bit as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for dynamically changing the window size for reliable channels in order to improve throughput, especially as the connection increases in latency.
This allows for more packets to be "in flight" and better saturate long connections, without overwhelming low latency ones.