-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast Train & Object Spawner #171
base: master
Are you sure you want to change the base?
Conversation
…the light brighter on it.
@Rxann @tyackman @maybegreat48 Give me your feedback, had to make a new draft PR because I fucked up the last one by editing files on github directly. |
Download the artifacts for this pull request: |
I think using the freecam like mbg said would be cool. It's a way more elegant approach than the sliders. Also the ability to attach objects together. Also should probably be able to disable collision for spawned objects |
If it can be done it would be great to add in, I am unsure of the approach but i know it can be done. Very similar to something like this As of current, the object/preview will move with your forward vector so if you move around it will move with you, the sliders are more for "Fine Tuning" the objects placement. |
Added Transparency to Object Spawner Added Collision toggle (for spawned objects)
Added Transparency to Object Spawner Added Collision toggle to spawned objects.
Formatted object list (hoopefully, 3rd times the charm._
All requested changes resolved, tested and working. |
@maybegreat48 @tyackman opinions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more models from the object list too.
char buffer[256]; | ||
strncpy(buffer, objectModelBuffer.c_str(), sizeof(buffer)); | ||
|
||
ImGui::InputTextWithHint("##objectmodel", "Object Model", buffer, sizeof(buffer), ImGuiInputTextFlags_CallbackCompletion, ObjectSpawnerInputCallback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use the frontend item InputTextWithHint
. Make sure to call .Draw()
if you choose to go this route, you probably should though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severity Code Description Project File Line Suppression State Details
Error C2440 '': cannot convert from 'initializer list' to 'YimMenu::InputTextWithHint'
InputTextWithHint("##objectmodel", "Object Model", &buffer, ImGuiInputTextFlags_CallbackCompletion, nullptr, ObjectSpawnerInputCallback)
.Draw();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer has to be a string, not a char.
Object models are going to be added little by little with each PR I create since the list is so huge, or with its own PR after this one gets merged, there is no way I would be able to add them all in within a reasonable amount of time. |
Why not just use a JSON or something? |
added all 20,000+ objects to the list
I got the list sorted out. over 20,000 objects in the list now, could probably be converted to a .json in the appdata folder though. |
As of right now, I don't know if it is good to build all of these into the binary. I think we might need a JSON file that users can download to use the object spawner. The amount of bloat to the amount of use ratio is undesirable currently. |
If you can implement the json i can just make the list for you. Im not sure how i would go about that. |
Look at the player database for example. It should be very close to something like that. |
Fast train is self explanatory, makes the train super fast.
Object Spawner - current state
https://streamable.com/uenxzn
Set on Fire option preview
https://streamable.com/2kstn4
// TODO
Sliders are there for fine tuning placement as currently, the object is set to the players forward vector, so when you move your character around it also moves with you.