Working invoker & natives.hpp #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
Looks good to me except the issue you stated. Haven't tested yet but there should definitely be a cache which gets inserted when the native is called the first time. Then it can be retrieved from the cache. If the vector3 isn't working yet you can mark it as a draft for now. |
|
All the issues you are describing are already fixed by maybegreat pr, this can be closed |
Merged
Will close once #11 is merged. |
|
This PR is being dismissed in favor of #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natives.hpp is generated from Natives Reference.
Practically a port over from YimMenu, only difference being the fact we no longer need maps due to the game offering a function that provides the address upon giving it a natives hash.
It appears the vector3 needs a fix.