Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libxl details parser #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Libxl details parser #8

wants to merge 2 commits into from

Conversation

paulorcf
Copy link

This parser get details about specific domain running Xen + libxl + libvirt.

@andrewgross
Copy link
Contributor

Hey Paulo,

Thanks for submitting this. I am keen to merge in the parser. However, I am unsure of the best way to handle the tests. I don't think it is correct to force everyone to download all tests when they want to use the parsers. However, I do want to have tests set up as they can be very useful.

Unfortunately when I set up this repo I did not set it up to be downloaded as a python package, but instead cloned as a repo. This makes it tricky to only include certain files in the distribution.

Thoughts?

@paulorcf
Copy link
Author

Hi Andrew,

Hum...
I think about that and agree about the tests. This is the reason I made two pull request:
Only libxl detail plugin:
paulorcf@ee7a68b

I'll think about that and send a new pull request for only parser/libxl.py.
I'm back after the weekend.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants