Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixed wrong label of tx_yoastseo_prominent_word table, removed exclude fields from table #562

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Nov 8, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Fixed the label of tx_yoastseo_prominent_word, wrong declaration within XLF file
  • Removed the exclude=1 of all the fields within the table

Relevant technical choices:

  • Since the tx_yoastseo_prominent_word table already has hideTable=true and the table is only used within AJAX requests, no need for exclude fields

Test instructions

This PR can be tested by following these steps:

  • Pull branch
  • Check within the Access rights of backend user (groups) if the label is showing and if there are no exclude fields

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #561

@RinyVT RinyVT merged commit 0c8c035 into main Nov 8, 2023
9 checks passed
@RinyVT RinyVT deleted the bugfix/561-label-missing branch November 8, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access Lists > Allowed excludefields: label is missing
1 participant