Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration-guidelines.md #303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

elvismdev
Copy link

@elvismdev elvismdev commented May 15, 2024

Update the property name to the correct one to obtain the current post object ID; otherwise, it returns nothing.

Update the @type key; otherwise, it will not appear in the ld+json script.

Fixes #

Summary

Relevant technical choices

Technical choices that affect more than this issue:

Test instructions

This PR can be acceptance tested by following these steps:
1.
1.
1.

Quality assurance

  • Security - I have thought about any security implications this code might add.
  • Performance - I have checked that this code doesn't impact performance (greatly).
  • Caching - I have analyzed the caching methods that this code touches and have added instructions to deal with those.
  • Tested - I have tested this code to the best of my abilities.
  • Automated tests - I have added unit tests to verify the code works as intended.
  • Testability - I have added unique ids to elements, so they can be located in automated testing.
  • I have altered a filename.
    • I have adjusted the ID property accordingly and updated all internal links.
    • I have added the redirect to the _redirects file in the root of the project.

Update the property name to the correct one to obtain the current post object ID; otherwise, it returns nothing.

Update the `@type` key; otherwise, it will not appear in the `ld+json` script.
@elvismdev elvismdev marked this pull request as ready for review May 15, 2024 14:46
@mhkuu
Copy link
Contributor

mhkuu commented Sep 6, 2024

Thanks a lot for the patch @elvismdev!

  • The id vs. post_id-part: I guess id would indeed be more generic (e.g. for a term), but in this specific example post_id should work, right? Disclaimer: I did not run the code myself yet, I am trying to clean up the list of PRs 😄
  • The @-part was fixed through Fixes typo in integration-guidelines.md #306.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants