Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: make all classes either abstract or final #352

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Tests: make all classes either abstract or final #352

merged 1 commit into from
Dec 16, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 16, 2023

Context

  • Code QA/consistency

Summary

This PR can be summarized in the following changelog entry:

  • Code QA/consistency

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A No functional changes.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies

@jrfnl jrfnl added this to the 4.6 milestone Dec 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7229198258

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.203%
Totals Coverage Status
Change from base Build 7229177020: 0.0%
Covered Lines: 1236
Relevant Lines: 2462
💛 - Coveralls

@jrfnl jrfnl merged commit 65d40f4 into trunk Dec 16, 2023
22 checks passed
@jrfnl jrfnl deleted the JRF/tests-abstract-or-final branch December 16, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: non-user-facing yoast cs/qa
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfnl @coveralls