cleanup unused props

Yoast · Nov 13, 2024 · 6061d8f · 6061d8f
1 parent 4c3c87a
commit 6061d8f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/packages/js/src/components/SEMrushRelatedKeyphrasesModal.js b/packages/js/src/components/SEMrushRelatedKeyphrasesModal.js
@@ -153,7 +153,7 @@ class SEMrushRelatedKeyphrasesModal extends Component {
 	 * @returns {wp.Element} The RelatedKeyPhrasesModal modal component.
 	 */
 	render() {
-		const { keyphrase, location, whichModalOpen, isLoggedIn, shouldCloseOnClickOutside, onClose, countryCode, isRtl } = this.props;
+		const { keyphrase, location, whichModalOpen, isLoggedIn, onClose, countryCode, isRtl } = this.props;
 
 		const insightsLink = "https://www.semrush.com/analytics/keywordoverview/?q=" + encodeURIComponent( keyphrase ) +
 			"&db=" + encodeURIComponent( countryCode );
@@ -169,16 +169,16 @@ class SEMrushRelatedKeyphrasesModal extends Component {
 						{ __( "Get related keyphrases", "wordpress-seo" ) }
 					</NewButton>
 				</div> }
-				<Root context={{ isRtl }} >
+				<Root context={ { isRtl } }>
 					<Modal
-						isOpen={ keyphrase && whichModalOpen === location }
+						isOpen={ Boolean( keyphrase ) && whichModalOpen === location }
 						onClose={ onClose }
 						insightsLink={ insightsLink }
 						learnMoreLink={ "https://learnmore.semrush.com/" }
 					>
-					
+
 						<Slot name="YoastRelatedKeyphrases" />
-			
+
 					</Modal>
 				</Root>
 				{ ! isLoggedIn && <div className={ "yoast" }>
@@ -217,7 +217,7 @@ SEMrushRelatedKeyphrasesModal.propTypes = {
 	onOpenWithNoKeyphrase: PropTypes.func.isRequired,
 	onClose: PropTypes.func.isRequired,
 	onAuthentication: PropTypes.func.isRequired,
-	shouldCloseOnClickOutside: PropTypes.bool,
+	countryCode: PropTypes.string,
 	isRtl: PropTypes.bool,
 };
 
@@ -226,7 +226,7 @@ SEMrushRelatedKeyphrasesModal.defaultProps = {
 	location: "",
 	whichModalOpen: "none",
 	isLoggedIn: false,
-	shouldCloseOnClickOutside: true,
+	countryCode: "en_US",
 	isRtl: false,
 };
 

diff --git a/packages/js/src/containers/SEMrushRelatedKeyphrases.js b/packages/js/src/containers/SEMrushRelatedKeyphrases.js
@@ -27,7 +27,7 @@ export default compose( [
 			isPending: getSEMrushIsRequestPending(),
 			requestHasData: getSEMrushRequestHasData(),
 			lastRequestKeyphrase: getSEMrushRequestKeyphrase(),
-			
+
 		};
 	} ),
 	withDispatch( ( dispatch ) => {

diff --git a/packages/js/src/containers/SEMrushRelatedKeyphrasesModal.js b/packages/js/src/containers/SEMrushRelatedKeyphrasesModal.js
@@ -7,15 +7,13 @@ export default compose( [
 		const {
 			getSEMrushModalOpen,
 			getSEMrushLoginStatus,
-			getIsElementorEditor,
 			getSEMrushSelectedCountry,
 			getPreference,
 		} = select( "yoast-seo/editor" );
 
 		return {
 			whichModalOpen: getSEMrushModalOpen(),
 			isLoggedIn: getSEMrushLoginStatus(),
-			shouldCloseOnClickOutside: ! getIsElementorEditor(),
 			countryCode: getSEMrushSelectedCountry(),
 			isRtl: getPreference( "isRtl", false ),
 		};