324 tailwindify the errors and notices in the related keyphrase suggestions modal

[vraja-pro]

Context

Summary

This PR can be summarized in the following changelog entry:

• Implements new design for the warnings and errors in the related keyphrases suggestions modal.
• [@yoast/related-keyphrase-suggestions 0.1.0] Changes the design of the warnings and errors alerts in the related keyphrase suggestions.

Relevant technical choices:

• The pending notice is dropped since we have the loading table.
• relatedKeyphrases is a prop coming from Premium, checking for relatedKeyphrases includes checking for premium.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Check alerts for:
  • When there are more than 4 related keyphrases selected.
  • When the request failed
  • When there are no suggestions in the result
  • When the reaching the max requests for semrush:
    • The country selector should be hidden.
    • The button should have a lint to semrush upsell page.
    • Without premium, check that the premium upsell is hidden.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes Tailwindify the errors and notices in the related keyphrase suggestions modal

[coveralls]

Pull Request Test Coverage Report for Build e897c7d0b939493858af6978864834fd22861c8b

Details

• 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
• 6 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.01%) to 54.665%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/components/SEMrushRelatedKeyphrasesModalContent.js	4	6	66.67%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/components/modals/SEMrushLoading.js	1	0.0%
packages/js/src/components/modals/SEMrushMaxRelatedKeyphrases.js	1	0.0%
packages/js/src/components/modals/SEMrushRequestFailed.js	1	0.0%
packages/js/src/containers/SEMrushRelatedKeyphrases.js	1	0.0%
packages/js/src/components/modals/SEMrushLimitReached.js	2	0.0%

Totals
Change from base Build 7cce7dd70502c7f2b8b9e72de389ebde032a2f4e:	-0.01%
Covered Lines:	29739
Relevant Lines:	54688

---

💛 - Coveralls

[pls78]

CR: ✅
Acc: ⚠️ When a requestEmpty alert is shown, once the modal is closed and is opened again after the keyphrase has been changed, the alert is still visible just before the table is populated. Are we ok with this?

[pls78]

Acc: ✅