323 fix design of links in the related keyphrase suggestions modal semrush

[vraja-pro]

Context

Summary

This PR can be summarized in the following changelog entry:

• Implements new design for the related keyphrase suggestions modal with footer containing relevant links.
• [@yoast/related-keyphrase-suggestions 0.1.0] Adds the modal for related keyphrase suggestions, including links for insights and learn more in the footer.

Relevant technical choices:

• I removed the option to dismiss the modal when clicking outside the modal. That was implemented following P1 1263 fix modals auto close in elementor in the PR https://github.com/Yoast/wordpress-seo-premium/pull/3551. With this PR there is not need to disable that.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Edit a post with focus keyphrase.
• Click on "Get related keyphrase" and log in to your semrush account.
• Return to editing the post and check that you are getting a modal with the related keyphrase suggestions.
• Check the modal has a footer with the "Get insights..." link and "Learn more.." link with the following icons and colors:
  
• Check that the footer is sticky and when scrolling to the bottom of the suggestions table there is no "Get more insights..." link.
• Check that the "Get insights" link is https://www.semrush.com/analytics/keywordoverview/?q={keyphrase}&db={countryCode}
• Check that the learn more link is "yoa.st/3-v" with params and once clicked it is directing to: "https://yoast.com/help/volume-trend-related-keyphrases/#utm_source=yoast-seo&utm_medium=software&utm_term=volume-trend-keyphrases&utm_content=semrush-modal&php_version=8.1&platform=wordpress&platform_version=6.7-RC5&software=premium&software_version=23.9-RC4&days_active=12&shortlink=3-v"
• Follow the test instructions in https://github.com/Yoast/wordpress-seo-premium/pull/3551 for elementor.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes Fix design of links in the related keyphrase suggestions modal (semrush)

[coveralls]

Pull Request Test Coverage Report for Build 204b582663f27b7a649b0c882cc30a5e95bd33c0

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• 4 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.001%) to 54.666%

---

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/containers/SEMrushRelatedKeyphrasesModal.js	1	0.0%
packages/js/src/components/modals/Container.js	3	0.0%

Totals
Change from base Build b4aded0c071ca8f782f70b68e130c00af2bf8f7e:	0.001%
Covered Lines:	29737
Relevant Lines:	54687

---

💛 - Coveralls

[pls78]

CR: ✅ - just a tiny suggestion
Acc: ⚠️

• It seems to be there's something off with the shadow of the main div
  
• The top margin is too much?
  

[pls78]

Maybe we can use the URL() constructor here?