Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to also select Readability: Not Analyzed as option. #21834

Open
wants to merge 1 commit into
base: feature/dash-phase-1
Choose a base branch
from

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Nov 18, 2024

Context

  • We need another select option in the post overview.

Summary

This PR can be summarized in the following changelog entry:

  • Adds Not analyzed as a option in the readability filter.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Create a new post without a keyphrase. And save.
  • Go to the post overview and select Readability: Not analyzed and make sure your post shows up.
  • Add a keyphrase and save.
  • Make sure the post now longer shows up.
  • Repeat the instructions but with setting the post as no index. With a keyphrase saved.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 18, 2024
@thijsoo thijsoo added this to the feature/dash-phase-1 milestone Nov 18, 2024
@thijsoo thijsoo force-pushed the 524-create-a-url-for-readability-not-analyzed-posts-in-the-posts-page branch from b61c2dc to 5e27702 Compare November 18, 2024 14:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8bbb91dd7c29d125c0da5d0ad6a05afb07209d4d

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 54.49%

Totals Coverage Status
Change from base Build 56fbe7f4a3de866edfa6baf3525e129272b0511e: 0.004%
Covered Lines: 29760
Relevant Lines: 54899

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants