-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21848 decouple posts overview script enqueuing from class metaboxphp #21849
21848 decouple posts overview script enqueuing from class metaboxphp #21849
Conversation
Pull Request Test Coverage Report for Build 426f90f156f8588e69230aa50091f3ad533691b2Details
💛 - Coveralls |
38d2c18
to
686044a
Compare
fix height so that text would be cut from below hide screen reader text on mobile hide screen reader text and align bullet
686044a
to
f4beb1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin/metabox/class-metabox.php
Outdated
return; | ||
} | ||
|
||
$is_editor = self::is_post_edit( $pagenow ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd avoid using a variable here, since we only use the value once.
fix margin relative to the svg
20be0ae
to
3187809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR && Acc: ✅
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
edit-page
since this applies to the term overview page and post overview page. I added a comment in the css file. (And the global $pagenow name is "edit.php").Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes Decouple posts overview script enqueuing from class-metabox.php