Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21848 decouple posts overview script enqueuing from class metaboxphp #21849

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Nov 20, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Decouple post overview scripts from the metabox scripts.

Relevant technical choices:

  • I kept the name of the css and js files edit-page since this applies to the term overview page and post overview page. I added a comment in the css file. (And the global $pagenow name is "edit.php").

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to posts overview page.
  • Check you see the columns for the scores and cornerstone content.
  • Hovers those headers and check you see tooltip.
  • Resize the screen under 700 px width and toggle one of the post, check you see the columns without the screen reader text:
    Screenshot 2024-11-25 at 13 43 05
  • Go to categories overview page and repeat the test.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Decouple posts overview script enqueuing from class-metabox.php

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 20, 2024
@vraja-pro vraja-pro linked an issue Nov 20, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 426f90f156f8588e69230aa50091f3ad533691b2

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 54.668%

Changes Missing Coverage Covered Lines Changed/Added Lines %
admin/class-meta-columns.php 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
admin/metabox/class-metabox.php 1 21.87%
Totals Coverage Status
Change from base Build b4aded0c071ca8f782f70b68e130c00af2bf8f7e: 0.003%
Covered Lines: 29741
Relevant Lines: 54689

💛 - Coveralls

@vraja-pro vraja-pro force-pushed the 21848-decouple-posts-overview-script-enqueuing-from-class-metaboxphp branch from 38d2c18 to 686044a Compare November 21, 2024 14:19
fix height so that text would be cut from below

hide screen reader text on mobile

hide screen reader text and align bullet
@vraja-pro vraja-pro force-pushed the 21848-decouple-posts-overview-script-enqueuing-from-class-metaboxphp branch from 686044a to f4beb1b Compare November 21, 2024 14:49
Copy link
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acc ⚠️ :

  • The cornerstone content X icon is misaligned when switching to small screen size
    Screenshot 2024-11-25 at 12 03 24

return;
}

$is_editor = self::is_post_edit( $pagenow );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid using a variable here, since we only use the value once.

fix margin relative to the svg
@vraja-pro vraja-pro force-pushed the 21848-decouple-posts-overview-script-enqueuing-from-class-metaboxphp branch from 20be0ae to 3187809 Compare November 25, 2024 11:42
@pls78 pls78 added this to the feature/plugin-fixes milestone Nov 25, 2024
Copy link
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit ae05a9f into feature/plugin-fixes Nov 25, 2024
23 checks passed
@pls78 pls78 deleted the 21848-decouple-posts-overview-script-enqueuing-from-class-metaboxphp branch November 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple posts overview script enqueuing from class-metabox.php
4 participants