-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: add tooltip to not analyzed #21870
Open
igorschoester
wants to merge
8
commits into
feature/dash-phase-1
Choose a base branch
from
337-add-tool-tip-for-not-analyzed-label
base: feature/dash-phase-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dashboard: add tooltip to not analyzed #21870
igorschoester
wants to merge
8
commits into
feature/dash-phase-1
from
337-add-tool-tip-for-not-analyzed-label
+368
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role * add aria-describedby that needs an ID * use button as a focusable element, this is a hacky solution * add aria-disabled to the button to indicate that it does nothing * show the tooltip on focus and hover * hide the tooltip on Escape press * move the tooltip out of the button so it does not influence the content (an alternative, less ideal would be to add aria-hidden) * add a wrapper to still get the tooltip positioning with relative * use focus-visible so the keyboard user still sees the focus Missing: adjustment of the tooltip display styling. As that is inside the UI library, more commits incoming to try to move this solution there.
igorschoester
added
the
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
label
Nov 27, 2024
Components to use the Tooltip element in a a11y friendly manner
igorschoester
force-pushed
the
337-add-tool-tip-for-not-analyzed-label
branch
from
November 27, 2024 15:53
e240361
to
68a9c95
Compare
Pull Request Test Coverage Report for Build 01c57b68a1d3880115f7af3a0793323b75d43062Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
vraja-pro
reviewed
Nov 28, 2024
bit of a hack, but better than outside the screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
TooltipContainer
component that handles a11y functionality around the Tooltip element.useKeydown
hook to handle thekeydown
event listener subscription.Relevant technical choices:
aria-describedby
only when there is a tooltip (passingundefined
will stop the attribute from being added)The tooltip is not fully a11y compatible due to no element to focus on and our UI library needing improvementsImprove a11y of the tooltip
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Not analyzed
scores (both SEO & readability)We haven’t analyzed this content yet. Please open it in your editor, ensure a focus keyphrase is entered, and save it so we can start the analysis.
Not analyzed
by keyboardNot analyzed
receives focus.yst-tooltip-trigger
) around theNot analyzed
in the inspector, and open the Accessibility tabName
isNot analyzed
followed by the amount, e.g.3
Description
is the contents of the tooltip[DEV only] Storybook
yarn workspace @yoast/ui-library storybook
Regression
Get related keyphrases
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/reserved-tasks/issues/337