Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the incorrect stemming of the verb "revocares" and of a word that looks like a verb but is not #21999

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
+8,163 −8,144
Open

Fixes the incorrect stemming of the verb "revocares" and of a word that looks like a verb but is not #21999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f103dc
adds an extra check for verb suffixes after updating rvText and check…
iolse Jan 24, 2025
f6f132e
delete if statement as it does not influence the result of the failin…
iolse Jan 28, 2025
616705a
adds a check for two failing tests that also replces the previous two…
iolse Jan 29, 2025
8250e42
add check for canonical stems and stores suffixes in a variable, adds…
iolse Jan 29, 2025
144c976
re-create the goldStandard list fro Spanish and add it statement to g…
iolse Feb 3, 2025
e1433e0
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into 234-fix-s…
iolse Feb 5, 2025
98b1896
fixes lintJS errors
iolse Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/yoastseo/spec/languageProcessing/languages/es/helpers/internal/stemSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const wordsToStem = [
[ "martes", "martes" ],
[ "microondas", "microondas" ],
[ "jesús", "jesus" ],
[ "práxedes", "praxedes" ],
// Input noun with: singular: -z, plural: -ces
[ "actriz", "actriz" ],
[ "actrices", "actriz" ],
Expand Down Expand Up @@ -73,7 +74,7 @@ const wordsToStem = [
[ "comienzo", "comenz" ],
// Input a word that ends in a common verb suffix.
[ "saltaron", "salt" ],
// [ "revocares", "revoc" ],
[ "revocares", "revoc" ],
// Input a word that ends in -os, -s, -a, -o, -á, -í,-ó, -é, -e.
[ "agostinas", "agostin" ],
[ "boboré", "bobor" ],
Expand All @@ -88,9 +89,10 @@ const wordsToStem = [
// Input a word that ends in -en, -es, -éis, -emos and is preceded by gu.
[ "distinguen", "distingu" ],
[ "alarguemos", "alarg" ],
// Input a word that looks like a verb form but it's not.
// Input a word that looks like a verb form, but it's not.
// [ "cabalgada", "cabalgad" ],
[ "abacería", "abaceri" ],
[ "lugar", "lugar" ],
// Input a word that looks like a verb form and is on the list of stems that belong together.
[ "san", "san" ],
[ "virgen", "virgen" ],
Expand Down
7 changes: 4 additions & 3 deletions ...eo/spec/languageProcessing/languages/es/helpers/internal/stemmerCoverage/generateStems.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8169,7 +8169,8 @@ const wordsToStem = [
const wordsToStemWithoutFunctionWords = filterFunctionWordsFromArray( wordsToStem, functionWords );

describe( "Generate stems for Spanish words", () => {
const corpusWithStems = wordsToStemWithoutFunctionWords.map( word => [ word, stem( word, morphologyDataES ) ] );

console.log( JSON.stringify( corpusWithStems ) );
it( "Generate stems for Spanish words", () => {
const corpusWithStems = wordsToStemWithoutFunctionWords.map( word => [ word, stem( word, morphologyDataES ) ] );
console.log( JSON.stringify( corpusWithStems ) );
} );
} );
Loading