Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds edit button according to the new API #22014

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Feb 3, 2025

Context

  • Adds edit button to the top 5 most popular table.

Summary

This PR can be summarized in the following changelog entry:

  • Adds edit button to unreleased site kit table for the most popular content.
  • [@yoast/ui-library 0.1.0] Removes paddings for table minimal variant of the first and last cells of the Table element.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Apply the following patch: edit-button.patch
  • Go to Yoast SEO->General
  • Check you see a table in the dashboard for most popular content with dummy data.
  • Check there is. new Actions column
  • Check the first result only has an enabled edit button at the end of the row.
  • Check the reset of the rows has disabled button.
  • Check the button matches the design

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 3, 2025
@coveralls
Copy link

coveralls commented Feb 3, 2025

Pull Request Test Coverage Report for Build e32bac77dbddf4f5958b05b211970a73fb9b3fd8

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 57.642%

Files with Coverage Reduction New Missed Lines %
packages/js/src/integrations-page/recommended-integrations.js 5 0.0%
Totals Coverage Status
Change from base Build 21de2bc4f4669abf595c28a27dd2b387347cb731: 0.05%
Covered Lines: 13487
Relevant Lines: 23054

💛 - Coveralls

@vraja-pro vraja-pro requested a review from a team as a code owner February 4, 2025 11:06
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🏗️

  • About the UI library changelog entry: AFAIK the table variant has not been released yet so that would make this change also non-user-facing, right?
  • About the match vs design test instruction. The design seems to have changed, so that will fail acceptance now

Comment on lines 52 to 54
&:first-child {
@apply yst-ps-0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: there are Tailwind modifiers for this. E.g. you could write this as first:yst-ps-0.

Also wondering if this is really UI library or rather the implementation in our table because of the numbers.
It seems to me we actually don't want this in the UI library.

Copy link
Contributor Author

@vraja-pro vraja-pro Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually talked about it with Kai, and we looked at his example used in tailwind and they are doing the same thing and we wanted to include it in this variant.

packages/js/src/dashboard/components/table-widget.js Outdated Show resolved Hide resolved
The overflow hidden hides part of the button ring on focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants