Tests: allow for PHPUnit 8/9 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP_CodeSniffer 3.8.0 now allows for running the tests, which are based on the PHPCS native test suite, with PHPUnit 8 and 9.
This commit updates the package to take advantage of that.
Includes:
* Update the PHPUnit version requirements.
As this package no longer supports PHP < 7.2, PHPUnit 8 + 9 is all that's needed.
* Adding the PHPUnit 8+ cache file to `.gitignore`.
* Simplifications to the `quicktest` and `test` workflows.
Also, the code coverage "high" run can now be run against PHP 8.3.
* Removing a no longer needed `--ignore-platform*` argument.
* MInor tweaks to the CS run on the code of YoastCS itself.
* Normalize a teardown method.
This was set up with an `@after` tag in anticipation of this PR, but before dropping support for PHP < 7.2.
As PHP < 7.2 has been dropped, we don't need to support PHPUnit 7 or lower anymore, so don't need this tweak to make the fixture methods cross-version compatible anymore.
Ref:
* PHPCSStandards/PHP_CodeSniffer 59
jrfnl
force-pushed
the
feature/composer-widen-phpunit-constraints
branch
from
396e173 to
8de22f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP_CodeSniffer 3.8.0 now allows for running the tests, which are based on the PHPCS native test suite, with PHPUnit 8 and 9.
This commit updates the package to take advantage of that.
Includes:
As this package no longer supports PHP < 7.2, PHPUnit 8 + 9 is all that's needed.
.gitignore.quicktestandtestworkflows. Also, the code coverage "high" run can now be run against PHP 8.3.--ignore-platform*argument.@aftertag in anticipation of this PR, but before dropping support for PHP < 7.2. As PHP < 7.2 has been dropped, we don't need to support PHPUnit 7 or lower anymore, so don't need this tweak to make the fixture methods cross-version compatible anymore.Ref: