Adding failing unit test to GeneralizedSuffixArray

Related to #196
Yomguithereal · Oct 4, 2022 · cffb94c · cffb94c
1 parent 7c043c2
commit cffb94c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/suffix-array.js b/suffix-array.js
@@ -190,7 +190,7 @@ function convert(target) {
   }
 
   // Padding the array
-  for (; i < paddingOffset; i++)
+  for (i = length; i < length + paddingOffset; i++)
     array[i] = 0;
 
   return array;

diff --git a/test/suffix-array.js b/test/suffix-array.js
@@ -87,4 +87,27 @@ describe('GeneralizedSuffixArray', function() {
       ['the', 'mouse']
     );
   });
+
+  it.skip('should work with int values (issue #196).', function() {
+    var suffixArray = new GeneralizedSuffixArray([
+      '1234',
+      '234',
+      '1234'
+    ]);
+
+    var result = suffixArray.longestCommonSubsequence();
+
+    assert.deepStrictEqual(result, '234');
+
+    // TODO: fix sentinel to be lower than anything else in the token case
+    suffixArray = new GeneralizedSuffixArray([
+      [1, 2, 3, 4],
+      [2, 3, 4],
+      [1, 2, 3, 4]
+    ]);
+
+    result = suffixArray.longestCommonSubsequence();
+
+    assert.deepStrictEqual(result, [2, 3, 4]);
+  });
 });