fix: initialize thread on import

Yonom · Dec 14, 2024 · 5d07137 · 5d07137
1 parent fd1623f
commit 5d07137
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/packages/react/src/runtimes/core/BaseThreadRuntimeCore.tsx b/packages/react/src/runtimes/core/BaseThreadRuntimeCore.tsx
@@ -32,6 +32,7 @@ type BaseThreadAdapters = {
 
 export abstract class BaseThreadRuntimeCore implements ThreadRuntimeCore {
   private _subscriptions = new Set<() => void>();
+  private _isInitialized = false;
 
   protected readonly repository = new MessageRepository();
   public abstract get adapters(): BaseThreadAdapters | undefined;
@@ -161,11 +162,20 @@ export abstract class BaseThreadRuntimeCore implements ThreadRuntimeCore {
     this._notifySubscribers();
   }
 
+  protected ensureInitialized() {
+    if (!this._isInitialized) {
+      this._isInitialized = true;
+      this._notifyEventSubscribers("initialize");
+    }
+  }
+
   public export() {
     return this.repository.export();
   }
 
   public import(data: ExportedMessageRepository) {
+    this.ensureInitialized();
+
     this.repository.import(data);
     this._notifySubscribers();
   }

diff --git a/packages/react/src/runtimes/external-store/ExternalStoreThreadRuntimeCore.tsx b/packages/react/src/runtimes/external-store/ExternalStoreThreadRuntimeCore.tsx
@@ -133,15 +133,18 @@ export class ExternalStoreThreadRuntimeCore
           )
             return cache;
 
+          const messageLike = store.convertMessage(m, idx);
           const newMessage = fromThreadMessageLike(
-            store.convertMessage(m, idx),
+            messageLike,
             idx.toString(),
             autoStatus,
           );
           (newMessage as any)[symbolInnerMessage] = m;
           return newMessage;
         });
 
+    if (messages.length > 0) this.ensureInitialized();
+
     for (let i = 0; i < messages.length; i++) {
       const message = messages[i]!;
       const parent = messages[i - 1];

diff --git a/packages/react/src/runtimes/local/LocalThreadRuntimeCore.tsx b/packages/react/src/runtimes/local/LocalThreadRuntimeCore.tsx
@@ -19,8 +19,6 @@ export class LocalThreadRuntimeCore
   extends BaseThreadRuntimeCore
   implements ThreadRuntimeCore
 {
-  private _isInitialized = false;
-
   public readonly capabilities = {
     switchToBranch: true,
     edit: true,
@@ -83,15 +81,8 @@ export class LocalThreadRuntimeCore
     if (hasUpdates) this._notifySubscribers();
   }
 
-  private _ensureInitialized() {
-    if (!this._isInitialized) {
-      this._isInitialized = true;
-      this._notifyEventSubscribers("initialize");
-    }
-  }
-
   public async append(message: AppendMessage): Promise<void> {
-    this._ensureInitialized();
+    this.ensureInitialized();
 
     const newMessage = fromCoreMessage(message, {
       attachments: message.attachments,
@@ -108,7 +99,7 @@ export class LocalThreadRuntimeCore
   }
 
   public async startRun(parentId: string | null): Promise<void> {
-    this._ensureInitialized();
+    this.ensureInitialized();
 
     this.repository.resetHead(parentId);