fix: external store initialMessages sync (#631)

Yonom · Aug 4, 2024 · a7e8ef6 · a7e8ef6
1 parent 07f76c8
commit a7e8ef6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/.changeset/poor-brooms-fetch.md b/.changeset/poor-brooms-fetch.md
@@ -0,0 +1,5 @@
+---
+"@assistant-ui/react": patch
+---
+
+refactor: rewrite external store sync
diff --git a/packages/react/src/runtimes/external-store/ExternalStoreThreadRuntime.tsx b/packages/react/src/runtimes/external-store/ExternalStoreThreadRuntime.tsx
@@ -41,28 +41,30 @@ export class ExternalStoreThreadRuntime implements ReactThreadRuntime {
   public isRunning = false;
   public converter = new ThreadMessageConverter();
 
-  private _store;
+  private _store!: ExternalStoreAdapter<any>;
 
   constructor(store: ExternalStoreAdapter<any>) {
-    this._store = store;
+    this.store = store;
   }
 
   public set store(store: ExternalStoreAdapter<any>) {
-    const oldStore = this._store;
-    this._store = store;
+    const oldStore = this._store as ExternalStoreAdapter<any> | undefined;
 
     // flush the converter cache when the convertMessage prop changes
-    if (oldStore.convertMessage !== store.convertMessage) {
-      this.converter = new ThreadMessageConverter();
-    } else if (
-      oldStore.isDisabled === store.isDisabled &&
-      oldStore.isRunning === store.isRunning &&
-      oldStore.messages === store.messages
-    ) {
-      // no update needed
-      return;
+    if (oldStore) {
+      if (oldStore.convertMessage !== store.convertMessage) {
+        this.converter = new ThreadMessageConverter();
+      } else if (
+        oldStore.isDisabled === store.isDisabled &&
+        oldStore.isRunning === store.isRunning &&
+        oldStore.messages === store.messages
+      ) {
+        // no update needed
+        return;
+      }
     }
 
+    this._store = store;
     const isRunning = store.isRunning ?? false;
     const isDisabled = store.isDisabled ?? false;
 
@@ -122,7 +124,6 @@ export class ExternalStoreThreadRuntime implements ReactThreadRuntime {
     this.messages = this.repository.getMessages();
     this.isDisabled = isDisabled;
     this.isRunning = isRunning;
-
     for (const callback of this._subscriptions) callback();
   }