fix: left controls being squished, right controls overflowing · YouTube-Enhancer/extension@18ccc33

Commit

fix: left controls being squished, right controls overflowing

fix: left controls being squished, right controls overflowing
* refactor: center input arrows

* build(deps-dev): bump @types/react-dom from 18.2.17 to 18.2.18

Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.17 to 18.2.18.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: "@types/react-dom"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump @types/react from 18.2.45 to 18.2.47

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.45 to 18.2.47.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump postcss from 8.4.32 to 8.4.33

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.32 to 8.4.33.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.32...8.4.33)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump @typescript-eslint/parser from 6.15.0 to 6.18.1

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.15.0 to 6.18.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump typescript from 5.2.2 to 5.3.3

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.2.2 to 5.3.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.2.2...v5.3.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* style: formatting

* chore: rename volume boost feature name

* fix: menu item labels not updated when language changed

* refactor: improve types

* style: fix class name order and remove extra spaces

* refactor: add className to props

* refactor: add loading state to select, fetch languages in parallel

* build(deps-dev): bump @typescript-eslint/eslint-plugin

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.15.0 to 6.18.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump vite from 4.5.1 to 5.0.11

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.1 to 5.0.11.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.0.11/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump @types/node from 20.10.5 to 20.11.0

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.10.5 to 20.11.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump vite-plugin-css-injected-by-js from 3.3.0 to 3.3.1

Bumps [vite-plugin-css-injected-by-js](https://github.com/marco-prontera/vite-plugin-css-injected-by-js) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/marco-prontera/vite-plugin-css-injected-by-js/releases)
- [Commits](marco-prontera/vite-plugin-css-injected-by-js@v3.3.0...v3.3.1)

---
updated-dependencies:
- dependency-name: vite-plugin-css-injected-by-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump semantic-release from 22.0.8 to 23.0.0

Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 22.0.8 to 23.0.0.
- [Release notes](https://github.com/semantic-release/semantic-release/releases)
- [Commits](semantic-release/semantic-release@v22.0.8...v23.0.0)

---
updated-dependencies:
- dependency-name: semantic-release
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump @types/node from 20.11.0 to 20.11.5

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.0 to 20.11.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* work in progress refactor

* button placement almost done
need to code making and placing buttons

* still needs some work

* fix: per video volume boost was disabled when adjusting boost

* feat: button placement
#247

* translations: Add new strings

* Update node version

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Loading branch information

VampireChicken12 and dependabot[bot] authored Jan 22, 2024

1 parent 9e08dd6 commit 18ccc33

public/contentStyle.css

-Original file line number
+Diff line change
@@ Expand Up / @@ -18,9 +18,11 @@ body.no-scroll .yte-button-tooltip { @@
     	padding: 8px 9px !important;
     	transform: translate(-50%, -75%) !important;
     }
     .maximized_chapter {
     	width: 100% !important;
     }
     .maximized_video {
     	width: 100vw !important;
     	height: 100vh !important;
@@ Expand All / @@ -29,6 +31,7 @@ body.no-scroll .yte-button-tooltip { @@
     	object-fit: contain !important;
     	background: black !important;
     }
     .maximized_video_container {
     	position: fixed !important;
     	top: 0 !important;
@@ Expand All / @@ -37,10 +40,12 @@ body.no-scroll .yte-button-tooltip { @@
     	height: 100vh !important;
     	z-index: 2020 !important;
     }
     .maximized_controls {
     	width: 97vw !important;
     	right: 12px !important;
     }
     .yte-maximize-player-button {
     	opacity: 0.9;
     	display: inline-block;
@@ Expand All / @@ -51,3 +56,11 @@ body.no-scroll .yte-button-tooltip { @@
     	transition: opacity 0.1s cubic-bezier(0.4, 0, 1, 1);
     	overflow: hidden;
     }
+    .ytp-chapter-container {
+    	flex: 1 !important;
+    }
+    .ytp-right-controls {
+    	display: flex !important;
+    }

src/features/buttonPlacement/utils.ts

-Original file line number
+Diff line change
@@ Expand Up @@
     ) {
     	if (placement === "feature_menu") throw new Error("Cannot make a feature button for the feature menu");
     	const buttonExists = document.querySelector(`button#${getFeatureButtonId(featureName)}`) !== null;
-    	// TODO: fix left controls chapter container shrinking buttons
-    	// TODO: fix right controls button making control buttons overflow
     	const button = createStyledElement({
     		classlist: ["ytp-button"],
     		elementId: `${getFeatureButtonId(featureName)}`,
@@ Expand Down Expand Up @@
     		case "player_controls_left": {
     			const leftControls = document.querySelector<HTMLDivElement>(".ytp-left-controls");
     			if (!leftControls) return;
-    			leftControls.append(button);
+    			const timeDisplay = leftControls.querySelector<HTMLDivElement>(".ytp-time-display");
+    			if (!timeDisplay) return;
+    			timeDisplay.insertAdjacentElement("beforebegin", button);
     			break;
     		}
     		case "player_controls_right": {
@@ Expand Down @@

0 comments on commit `18ccc33`

Please sign in to comment.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit

There are no files selected for viewing

0 comments on commit `18ccc33`

Commit

There are no files selected for viewing

0 comments on commit 18ccc33

0 comments on commit `18ccc33`