Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DeviceInfo and DeviceConfig #120

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Improve DeviceInfo and DeviceConfig #120

merged 1 commit into from
Mar 19, 2024

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Mar 18, 2024

  • Implements Builder design pattern for DeviceInfo and deprecates existing constructors.
  • Adds support for reading DeviceConfig data from all existing pages.
  • Adds missing unit tests for both DeviceConfig and DeviceInfo classes.

@AdamVe AdamVe merged commit 6dc5b90 into main Mar 19, 2024
5 checks passed
@AdamVe AdamVe deleted the adamve/device_info branch March 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainnilsson dainnilsson dainnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamVe @dainnilsson