Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Dartコードのフォーマット設定とCIの更新 #913

Merged
merged 8 commits into from
Feb 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .cursor/rules/commit-rules.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
description: commit
globs:
---
# コミット作成手段

差分をチェックして 適切な粒度でコミットしてください。1コミットあたり30~100行程度の差分が望ましいです。コミットが完了したらpushすること。

コミットメッセージは 英語1単語のprefixをつけ 説明は1行で簡潔な日本語で示すこと
もし、1行で内容を要約できないのであれば コミットを分割するか コミットメッセージを複数行で記述することを検討してください

差分を取得する時は、`--no-pager`を使うこと
4 changes: 4 additions & 0 deletions .cursorrules → .cursor/rules/dart-rules.mdc
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
---
description: dart
globs: *.dart
---
// <https://github.com/PatrickJS/awesome-cursorrules/tree/main/rules/flutter-app-expert-cursorrules-prompt-file>
// (CC0 1.0 Universal License)
// Flutter App Expert .cursorrules
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/check-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ jobs:
- name: format
run: melos format

- name: fix
run: dart fix --apply .

- name: check difference
run: |
git add -N .
Expand Down Expand Up @@ -118,7 +121,7 @@ jobs:
- name: Report custom_lint result
run: |
echo "::add-matcher::.github/problem_matchers/custom_lint.json"
melos run report_custom_lint:ci --no-select || result=$?
melos run ci:report:custom_lint --no-select || result=$?
echo "::remove-matcher owner=custom_lint::"

if [ -n "$result" ]; then
Expand Down
2 changes: 1 addition & 1 deletion app/android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
android:enableOnBackInvokedCallback="true"
android:directBootAware="true">

<meta-data android:name="flutter_deeplinking_enabled" android:value="true" />
<meta-data android:name="flutter_deeplinking_enabled" android:value="false" />
<intent-filter android:autoVerify="true">
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.DEFAULT" />
Expand Down
Loading
Loading