Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First ldap implementation #179

Open
wants to merge 11 commits into
base: testing
Choose a base branch
from
Open

First ldap implementation #179

wants to merge 11 commits into from

Conversation

yalh76
Copy link
Member

@yalh76 yalh76 commented May 25, 2022

Problem

Solution

  • First ldap implementation

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@yalh76
Copy link
Member Author

yalh76 commented May 25, 2022

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@lapineige lapineige added enhancement New feature or request help wanted Extra attention is needed labels May 25, 2022
@lapineige
Copy link
Member

Thank you for working on this !

This will need quite a lot of testing, for both new and existing installations.

@yalh76
Copy link
Member Author

yalh76 commented Jun 24, 2022

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

@yalh76 yalh76 marked this pull request as ready for review June 27, 2022 18:45
@yalh76 yalh76 requested a review from lapineige June 27, 2022 18:45
@lapineige
Copy link
Member

This will need a lot of testing I guess (creating/removing user account, migrating from old Pixelfed without LDAP account, …).
I have no test server for that, so if anyone is willing to do it…

@yalh76
Copy link
Member Author

yalh76 commented Jul 31, 2022

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@lapineige
Copy link
Member

lapineige commented Jul 31, 2022 •
edited
Loading

Ok, I'm not sure that including php fix is the best thing here, but let's do it your way ;)
At least CI will be happy :D

@yalh76
Copy link
Member Author

yalh76 commented Aug 1, 2022

well as we already upgraded pixelfed to php7.4, I don't think we will have more issues

lapineige
lapineige approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@lapineige lapineige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need manual testing

@yalh76
Copy link
Member Author

yalh76 commented Aug 11, 2022

!testme

@yunohost-bot
Copy link
Contributor

May the CI gods be with you!
Test Badge

@yalh76
Copy link
Member Author

yalh76 commented Aug 18, 2022

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@yalh76
Copy link
Member Author

yalh76 commented Aug 28, 2022

!testme

@yunohost-bot
Copy link
Contributor

🎠
Test Badge

@lapineige
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

😜
Test Badge

@lapineige
Copy link
Member

lapineige commented Dec 18, 2022 •
edited
Loading 

1030018 INFO DEBUG -   - Installing spatie/db-dumper (2.21.1): Extracting archive
1030019 INFO DEBUG -   - Installing spatie/laravel-backup (6.16.5): Extracting archive
1030019 INFO DEBUG -   - Installing spatie/image-optimizer (1.6.2): Extracting archive
1030019 INFO DEBUG -   - Installing spatie/laravel-image-optimizer (1.6.4): Extracting archive
1030020 INFO DEBUG -   - Installing ezyang/htmlpurifier (v4.16.0): Extracting archive
1030020 INFO DEBUG -   - Installing stevebauman/purify (v3.0.3): Extracting archive
1030020 INFO DEBUG - Package swiftmailer/swiftmailer is abandoned, you should avoid using it. Use symfony/mailer instead.
1030021 INFO DEBUG - Generating optimized autoload files
1030021 INFO DEBUG - > Illuminate\Foundation\ComposerScripts::postAutoloadDump
1030021 INFO DEBUG - > @php artisan package:discover --ansi
1030022 INFO DEBUG -
1030022 INFO DEBUG - In User.php line 14:
1030022 INFO DEBUG -
1030023 INFO DEBUG -   Interface "LdapRecord\Laravel\Auth\LdapAuthenticatable" not found
1030024 INFO DEBUG -
1030025 INFO DEBUG -
1030025 INFO DEBUG - Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1
1030025 INFO DEBUG - + ynh_die '--message=Unable to install core dependencies with Composer.'

Sounds bad 😅

Base automatically changed from testing to master September 25, 2024 14:12
@ericgaspar ericgaspar changed the base branch from master to testing January 17, 2025 13:02
@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

May the CI gods be with you!
Test Badge

@yunohost-bot
Copy link
Contributor

Living in the past, are we? 🐮👁️
Test Badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lapineige lapineige lapineige approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yalh76 @yunohost-bot @lapineige @ericgaspar