Requires enum to implement FromStr #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
econf used to automatically generate string-to-enum conversions. However, this makes it less flexible when it comes to providing custom deserialization. Instead, relying on the FromStr trait offers more flexibility, especially when using a crate like strum.
julianskartor
approved these changes
Sep 2, 2024
yukinarit
force-pushed
the
require-enum-fromstr
branch
from
edf3c60 to
1bf1a02
Compare
yukinarit
force-pushed
the
require-enum-fromstr
branch
from
1bf1a02 to
7ee8867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change for enums!!
econf used to automatically generate string-to-enum conversions. However, this makes it less flexible when it comes to providing custom deserialization. Instead, relying on the
FromStrtrait offers more flexibility, especially when using a crate like strum.