Fx Pass and API additions #26
Conversation
>>>>>>>>>>>>>>>> New >>>>>>>>>>>>>>>> MISSILE MACROS Added a few different macros to handle a bigger variety of missiles. dodgepong also made a Pinaka Missile macro that uses some pretty intense math to calculate two center points for any group of targets to direct the missile and explosion fx to. Auto-Template for Pinaka Missile New macro to drop a template in place with an animated effect on the template. (Easily modified for various sizes or different animations) NEW MISSILE AIRBURST and CANNONAIRBURST MACRO this was at the request of a user to handle the hurricane cluster projector from SSMR. I don't intend to add ALL the new 1st party weapons, but this one was too cool not to do, plus I had one that was 95% the way there anyway. Its the same as the second missile video above, but uses a big bullet animation instead of a missile. Travels 60% of the distance between the source and the target group, detonates, spawns a bunch of bullets that fly at the targets the attack Hit, then an explosion plays on each hit target. NEW DEFAULTTECH Rebuilt from the ground up for a more E-War appeal and to apply to the widest possible variety of tech attacks. NEW MINI-GUN MACRO For Leviathan and the Dustgrave's Reaper Cannon SUPPORT FOR SOLSTICE RAIN New macro for the Battle Rifle, Predator Nexus triggers Nexus macro. SUPPORT FOR DUSTGRAVE New or modified macros for the new GMS and exotic equipment from Dustgrave. (Sorry, no LINAC unless one of our awesome devs could hook that up to retort loop.) (No new weapons from Siren's Song) >>>>>>>>>>>>>> Changes >>>>>>>>>>>>>> APOCALYPSE RAIL Removed .missed function (Its cooler if it always explodes). Moved animations from target 0 to the average location for all targets. RAILGUN Only one bullet animation, targeted at the furthest target from the source, plus one hit animation per hit target will play. Removed .missed function (Its a single bullet, travels in straight lines) COMBAT DRILL Fixed animations, wind animation only plays on hit, fewer hit FX play on miss to simulate a sort of "glancing off" AMR New prepatory sfx to introduce delay before it appears to fire verified timings BOLT THROWER Explosion animation will always play and will do so at the bolt's destination. The explosion SFX will only play on a hit. MISSILE swapped VFX from JK to JB2A, made missiles always explode even when missed, but explosion SFX only plays on hit. DEFAULTMELEE changed from JB2A's divine smite to their new default melee and tweaked timings. Adjusted so all animations occur in sequence. DD 288 rebuilt macro, closer to core book description. (Thanks for the great sound effect Walther Eghus II!) HAMMER and PLASMA MAUL Moved ground cracking impact effect behind tokens, adjusted scale, offset of hammer, knockout hammer effect, added glow, tweaked timings. Now correctly play all animations in sequence, order targeted. NANOBOT WHIP Tweaked timings, changed movement mode of animation to look better at longer range (its Threat 3) NEEDLEBEAM Adjusted timings of primary and secondary shots LASERS and PLASMARIFLE tweaked timings, fixed miss animations. PLASMA TALONS Adjusted impact fx, claw animation opacity and zIndex and timings POWER KNUCKLE minor adjustment to delay THERMAL RIFLE New prepatory weapon beep sound. TORCH Added smaller impact animation to the missed animation, impact sound only plays on hit. WARPIKE knockout spear, adjust glow to compensate (The wooden spear shaft looked bad for Lancer). trimmed endTime of spear swing sound. NEXUS Rebuilt from the ground up with custom soundfx, no longer requires JK assets. ANNIHILATOR Added impact vfx and sfx to miss animation ARCBOW Similar adjustments to Railgun macro, except changed the lightning effects out and made secondary lightning bolts spawn from the destination of the arrow to each token hit by the attack. AUTOPOD Removed .missed references. (Autopod never misses) CHARGED BLADE Now correctly plays animations 1x per token, correctly playing hit/miss animations in the order targeted. Swapped sword vfx and tweaked timings. BROOD SIBLINGS MOLT Swapped out Sword vfx for one with more consistant hit timing, added glow effect, tweaked timings. MORTAR Rebuilt w/ all JB2A effects, new bullet effect for the mortar shell to a central point for target group, subsequent explosion and then secondary explosions on targets hit. FLAMETHROWER Added fire effect on tokens hit PLASMATHROWER Added some funky hue and glow to approximate the insanity of hot plasma, swapped out vfx for a new one, added flame fx to tokens hit. DISPLACER added glow effect and adjusted hue for vfx, adjusted to target the center of a group of targets and tweaked timings. SLAG CANNON Complete overhaul. should seem a lot more like whats described in the book. REPEATING ANIMATIONS Wherever it makes more sense, weapons like HMG, Assault Rifle, Leviathan, etc. when missed, the entire burst will target one randomly offset area, instead of each bullet randomly offsetting anywhere around the target.
fix to tech attack macro
Added remaining weapons from Dustgrave NPC templates.
Adds several of FluffyPaws explosion macros and assets and a few others as well.
Add center point calculation methods to the API
Fix timing on repeating macros with miss functions. re-add CannonAirBurst macro, assign macros for SSMR NPC weapons.
|
@cirrahn I wanted to thank you again for your work on Lancer Weapon FX. Were nearing release and I've pushed this request to the main module. I thought I'd ping you and offer an opportunity to review everything. |
|
@Z3nner these are amazing! I cannot wait to use them in-game (especially the giant nukes). The overall level of quality is outstanding. Thank you for giving me a chance to review. I have done some brief testing and this is what I found:
It would also be nice to resolve the failing Check. Is that a fault of the test, or does a clean re-build of the pack need to be done? EDIT: I have now made #27 with an implementation of the pack-splitting idea! |
This checks for two things: - every macro listed in weaponEffects must exist - no other macros may exist
With this split it is easier for the user to find macros which must be triggered manually.
This prevents the package from being published to the NPM repository. As the project is a Foundry module, any such publish would be an accident!
|
I double checked Sequencer, and it shows the I like the improvements to the warpgate macros. Just the sort of thing I was looking for in order to make more like these. I noticed the issue with the Pinaka Missiles, but the game text requires that their areas of effect not overlap anyway, so the issue only pops up when it's being used incorrectly...which, while not intended kind of works out in my non-developer mind. I also liked separating the compendiums. I was sort of just including the extra effects as "easter eggs" but they are much better in their own basket. I fixed the loose hanging macros, turns out I had overwritten a little work I did to add the content from Dustgrave's NPCs. The only two left hanging are Power Knuckle and Plasma Projector. Power Knuckle was left behind when I reassigned that effect to the default melee effect, but left the other one in case users wanted to change it. Plasma Projector can actually go in the manual compendium. It's a fun combination of ridiculously large energy beam and absurd explosions. I don't know what the check is that's failing, honestly. I thought it was related to it being a branch, and not having a release, but I don't know. |
To avoid the API class becoming a monolith containing every function we can split parts out to their own files and classes. The `euclideanDistance` export is not strictly necessary but is an example of how a function from another file can be added to the API.
|
I have made #28 with some more fixes! The I have been poking the Pinaka Missiles some more and have found that it can still crash frequently when two valid targets are selected, if their X or Y position match (if they are far apart but in the same hex row/column), and infrequently when any two valid targets are selected.
The check is failing because the final two "manual" macros are not yet in the manual compendium. I have moved them in! |
The algorithm needs unique seed points to run correctly so instead of generating points which may be duplicates, get a unique list of all input points and then shuffle that list, and use the first k points. If this is not a sufficient number of points, extend the list with some synthetic unique additions by taking the largest X and Y values and adding an offset.
The "--pack" argument can be used to specify which directory the macro and JSON metadata should be generated in.
Adds several new macros, some of which improve or replace existing effects, while the rest are for supporting new content.
Adjusted, tweaked, modified, retimed, tuned, gutted, remodeled most of the macros in the module. Includes API adjustments from dodgepong for better maintainability and streamlining.