Moving preloading #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds preloading calls to all macros. Still to do, remove mass preloading from module.
cirrahn
approved these changes
Jun 22, 2024
| @@ -1,9 +1,10 @@ | |||
| { | |||
| "name": "foundry-lancer-weapon-fx", | |||
| "name": "lancer-weapon-fx", | |||
There was a problem hiding this comment.
This is my fault: I have my repo cloned to a directory called foundry-lancer-weapon-fx. This change is good!
If we add this to the package.json it will ensure consistent naming in package-lock.json no matter how it is installed:
"name": "lancer-weapon-fx",add "name": "lancer-weapon-fx",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preloading to the beginning of each effect macro, as intended for the preloading function.
Adjustments and tweaks to several macros for video/audio sync, likely necessary due to JB2A asset changes.
Where desirable, used more specific db addresses to reduce the number of files preloading.
Remove manual preloading macro and utilities folder.