Adding comparaison in ranking + improvements #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gylfirst
added
enhancement
Zalk0
force-pushed
the
ranking_sb_comparaison
branch
from
8ec46b5 to
6c61d0e
Compare
Zalk0
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes, focusing on improving the ranking system for Hypixel Skyblock guilds. The changes include adding new features to display ranking changes, refactoring existing functions to be asynchronous, and enhancing the ranking message generation.
This PR implements #56.
Enhancements to ranking system:
chouette/tasks.py: Modifiedskyblock_guild_rankingto include old ranking data and display ranking changes using embeds.chouette/utils/ranking.py: Added a newcalculate_player_positionfunction to determine if a player's ranking has changed and updatedgenerate_ranking_messageto use this function. [1] [2]Refactoring functions to be asynchronous:
chouette/utils/hypixel_data.py: Changedexperience_to_levelto be an asynchronous function.chouette/utils/ranking.py: Updatedformat_number,format_ranking_message, andupdate_statsto be asynchronous. [1] [2] [3]Display improvements:
chouette/utils/ranking.py: Enhanceddisplay_rankingto create multiple embeds if the ranking data exceeds the character limit, ensuring better readability.These changes improve the functionality and user experience of the ranking system by providing detailed ranking updates and making the codebase more efficient with asynchronous operations.