Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skyblock #54

Merged
merged 15 commits into from
Jun 21, 2024
Merged

Skyblock #54

merged 15 commits into from
Jun 21, 2024

Conversation

gylfirst
Copy link
Collaborator

@gylfirst gylfirst commented Jun 12, 2024 •
edited
Loading

closes #46

@gylfirst gylfirst added the enhancement New feature or request label Jun 12, 2024
gylfirst and others added 3 commits June 14, 2024 19:31
@gylfirst
feat(skyblock): add guild ranking feature
88bea6c
@gylfirst
feat: add HYPIXEL_RANK_CHANNEL configuration option
1f912e8
@Zalk0
fix: cleanup descriptions and refactor networth call
836f276 
- move hypixel_discord function
- add discord pseudo check to skyblock link command
- make skyblock link ephemeral
- save data only if profile changed when calling pseudo_to_profile
@gylfirst
Copy link
Collaborator Author

Overview:

This pull request encompasses significant updates and new implementations to enhance the functionality of our system, including updating to the new Hypixel API (v2), implementing a new database, and improving player information storage and ranking display.

Changes:

  1. Update to Hypixel API (v2):

    • Migrated all existing functions to utilize the new Hypixel API (v2).
    • Refactored code to accommodate any changes in API endpoints and data structures.

  2. Implement New Database:

    • Designed and integrated a new database schema to efficiently store player information.
    • Ensured compatibility and optimized data retrieval processes for improved performance.

  3. Monthly Player Information Updates:

    • Implemented automated monthly updates to refresh player data.

  4. Ranking System:

    • Created a ranking system based on the stored data.
    • Developed an automated process to publish the updated rankings into a designated channel upon each update.

  5. Display Levels Instead of XP:

    • Modified the display format to show player levels rather than experience points amount.

Benefits:

  • Improved Data Accuracy and Freshness: Regular monthly updates ensure that player information is always current.
  • Enhanced User Experience: Displaying levels provides a clearer and more intuitive understanding of player progress.
  • Community Engagement: Publishing rankings fosters competition and engagement within the community.
  • Future-Proofing: Leveraging Hypixel API (v2) and a robust database ensures long-term scalability and maintainability.

Future updates:

@gylfirst gylfirst marked this pull request as ready for review June 21, 2024 10:33
@gylfirst gylfirst requested a review from Zalk0 June 21, 2024 10:33
@Zalk0
fix: improve ranking.py and remove ranking.toml
4de1967 
- the file ranking.toml was used for debugging purposes while testing the feature
- don't use pseudo_to_profile in update_stats
- rename variables to french
- parse_data now only parses and doesn't save the data
Zalk0
Zalk0 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Owner

@Zalk0 Zalk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, vérifie mes modifs pour ranking mais sinon ça me parait bon

@gylfirst gylfirst merged commit 6fbd585 into dev Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zalk0 Zalk0 Zalk0 approved these changes

Assignees

@gylfirst gylfirst

@Zalk0 Zalk0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gylfirst @Zalk0