-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(net): Deleted unused NeverAttemptedAlternate peer state #7982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
extra-reviews
This PR needs at least 2 reviews to merge
label
Nov 22, 2023
upbqdn
previously approved these changes
Nov 23, 2023
This removes internal unused code, so it doesn't need extra reviews. |
@Mergifyio refresh |
✅ Pull request refreshed |
github-actions
bot
added
the
extra-reviews
This PR needs at least 2 reviews to merge
label
Nov 23, 2023
github-actions
bot
added
the
extra-reviews
This PR needs at least 2 reviews to merge
label
Nov 26, 2023
teor2345
changed the title
cleanup(net): Remove the NeverAttemptedAlternate peer state
cleanup(net): Deleted unused NeverAttemptedAlternate peer state
Nov 26, 2023
upbqdn
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to remove an unused peer state.
This is a cleanup from #7824. I think we can close that tracking issue after it merges, as soon as we decide what to do about the more complicated cleanups.
PR Author Checklist
Check before marking the PR as ready for review:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Testing
This also involves updating tests, which currently give good coverage.
Review
This is a low priority cleanup. I don't want to merge it into PR #7977, just in case we need to revert it.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.