Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(net): Deleted unused NeverAttemptedAlternate peer state #7982

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 22, 2023

Motivation

We want to remove an unused peer state.

This is a cleanup from #7824. I think we can close that tracking issue after it merges, as soon as we decide what to do about the more complicated cleanups.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Remove the NeverAttemptedAlternate peer state and everything that depends on it
  • Add a Debug impl for CandidateSet

Testing

This also involves updating tests, which currently give good coverage.

Review

This is a low priority cleanup. I don't want to merge it into PR #7977, just in case we need to revert it.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ A-network Area: Network protocol updates or fixes C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Nov 22, 2023
@teor2345 teor2345 self-assigned this Nov 22, 2023
@teor2345 teor2345 requested a review from a team as a code owner November 22, 2023 21:54
@teor2345 teor2345 requested review from upbqdn and removed request for a team November 22, 2023 21:54
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Nov 22, 2023
upbqdn
upbqdn previously approved these changes Nov 23, 2023
@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Nov 23, 2023
@teor2345
Copy link
Contributor Author

This removes internal unused code, so it doesn't need extra reviews.

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Nov 23, 2023

refresh

✅ Pull request refreshed

@teor2345 teor2345 changed the base branch from vers-to-cache to main November 23, 2023 23:54
@teor2345 teor2345 dismissed upbqdn’s stale review November 23, 2023 23:54

The base branch was changed.

@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Nov 23, 2023
@upbqdn upbqdn removed the extra-reviews This PR needs at least 2 reviews to merge label Nov 24, 2023
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Nov 26, 2023
@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Nov 26, 2023
@teor2345 teor2345 changed the title cleanup(net): Remove the NeverAttemptedAlternate peer state cleanup(net): Deleted unused NeverAttemptedAlternate peer state Nov 26, 2023
mergify bot added a commit that referenced this pull request Nov 27, 2023
@mergify mergify bot merged commit 4aaeb4c into main Nov 28, 2023
97 checks passed
@mergify mergify bot deleted the cleanup-alt branch November 28, 2023 00:30
@arya2 arya2 mentioned this pull request Nov 29, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants