docs(workflow): adds a description at the top of each file #8009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
A-docs
Ah, sorry about that, I added descriptions as part of the external repository patch PRs, because it was starting to get really confusing. |
upbqdn
approved these changes
Dec 4, 2023
Co-authored-by: Marek <[email protected]>
upbqdn
approved these changes
Dec 4, 2023
|
I think there are bugs in this branch that are fixed in the base PR, so I just updated it. |
|
Ah, that doesn't seem to work, maybe the bugs are still in the base PR. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
* ref(workflow): move most scripts to their own executable * debug: JSON value * fix(scripts): move remaining script to its own file * fix(script): revert to the correct disk search logic * fix(scripts) * fix(scripts): use correct NETWORK with lowercase * fix: typo * fix(script): wrong variable assignment * fix(script): use correct return values inside a function * fix(script): fix value assigment * test: debug * fix(script): make disk conditions simpler * fix(script): export variables to the `shell` executing the script * fix(script): do not fail on expected unbound variables * test: output * fix(scripts): do not `echo` a variable more than once * fix(scripts): typo * docs(workflow): adds a description at the top of each file (#8009) Co-authored-by: Marek <[email protected]> Co-authored-by: teor <[email protected]> --------- Co-authored-by: teor <[email protected]> Co-authored-by: Alfredo Garcia <[email protected]> Co-authored-by: Marek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's better if member of the team, existing or new contributors, can understand what a workflow file is meant to do (overall) before deep diving into it and trying to understand it piece by piece.
Closes #7607
Depends-On: #8009
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Review
This PR depends on changes on the scrips, so I didn't had to make these changes twice.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
None