Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot(change): Exclude hyper from production dependabot upgrades #8010

Merged
merged 1 commit into from
Nov 28, 2023
Merged

dependabot(change): Exclude hyper from production dependabot upgrades #8010

merged 1 commit into from
Nov 28, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Nov 27, 2023

Motivation

We want to exclude hyper from future dependabot PRs until jsonrpc-http-server starts using v1 so that they can be merged without changes.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Add |hyper to the exclude pattern for production dependencies.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

  • Revert this PR when jsonrpc-http-server starts using hyper v1.x.x

@arya2 arya2 added A-dependencies Area: Dependency file updates P-Medium ⚡ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Nov 27, 2023
@arya2 arya2 requested a review from a team as a code owner November 27, 2023 22:38
@arya2 arya2 requested review from teor2345 and removed request for a team November 27, 2023 22:38
@arya2 arya2 self-assigned this Nov 27, 2023
teor2345
teor2345 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mergify bot added a commit that referenced this pull request Nov 27, 2023
@mergify
Merge of #8010
7760adb
@mergify mergify bot mentioned this pull request Nov 27, 2023
Closed
@mergify mergify bot merged commit de978d0 into main Nov 28, 2023
92 checks passed
@mergify mergify bot deleted the skip-hyper-dep-updates branch November 28, 2023 00:30
teor2345 added a commit that referenced this pull request Nov 28, 2023
@teor2345
Revert "excludes hyper from production dependabot upgrades (#8010)"
880c21e 
This reverts commit de978d0.
@teor2345 teor2345 mentioned this pull request Nov 28, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 29, 2023
@teor2345
Revert "excludes hyper from production dependabot upgrades (#8010)" (#…
961b720 
…8016)

This reverts commit de978d0.
@arya2 arya2 mentioned this pull request Nov 29, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@arya2 arya2

Labels
A-dependencies Area: Dependency file updates C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arya2 @teor2345