-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(ci): When building crates individually, build all targets, and run clippy #8024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Category: This is a bug
A-devops
Area: Pipelines, CI/CD and Dockerfiles
P-High 🔥
I-build-fail
Zebra fails to build
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
A-blockchain-scanner
Area: Blockchain scanner of shielded transactions
labels
Nov 28, 2023
teor2345
changed the title
change(ci): Run clippy and build all targets on all crates individually
change(ci): When building crates individually, build all targets, and run clippy
Nov 29, 2023
teor2345
force-pushed
the
tests-indiv
branch
from
November 29, 2023 03:37
092ec65
to
12ab39b
Compare
teor2345
force-pushed
the
tests-indiv
branch
from
November 29, 2023 05:34
12ab39b
to
9afc789
Compare
teor2345
force-pushed
the
tests-indiv
branch
from
November 29, 2023 20:02
9afc789
to
4e2192d
Compare
oxarbitrage
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-blockchain-scanner
Area: Blockchain scanner of shielded transactions
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-bug
Category: This is a bug
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-build-fail
Zebra fails to build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some build failures that only show up when the tests are built in an individual crate. This impacts Zebra's usability for external developers.
This PR runs clippy and builds all targets in all crates individually. Then it fixes any errors that turn up.
This is related to #8019 and the scanner work in general, but these errors could happen in any crate.
PR Author Checklist
Check before marking the PR as ready for review:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
zebrad
test build takes more than 14 GB disk spaceRelated cleanups:
Admin:
Testing
This PR fixes and adds tests.
Review
This is urgent because it will cause merge conflicts with upcoming changes.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.