-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan blocks with sapling keys and write the results to the database #8040
Conversation
Seems to work in my manual tests, and quickly too:
This is only running on one core, and doing each key twice (dfvk and ivks). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Looks really good to me, i left a few questions and optionals.
Motivation
This PR scans the blockchain and adds the scanner results to the scanner database.
Close #8021
I think it might also
close #7953
but @upbqdn feel free to replace that code with your PR, and re-open that ticket if it's not finished.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
The changelog summary for 1.5.0 already talks about scanning.
Complex Code or Requirements
I tried scanning with all the keys to make sure it would work, but we only really need to scan with the full viewing key. I couldn't find the encoding for individual viewing keys, so I left that until later.
There's also a bunch of
spawn_blocking()
calls in here.Solution
Changes:
Fixes:
Testing
I manually tested this, getting it in CI is ticket #8037
Review
@oxarbitrage might want to review the scanner bits, and @upbqdn the block/state bits?
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
#8022 then lots of testing: