Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(beta-toolchain): Warnings #8404

Merged
merged 8 commits into from
Apr 18, 2024
Merged

fix(beta-toolchain): Warnings #8404

merged 8 commits into from
Apr 18, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Apr 15, 2024 •
edited by arya2
Loading

Motivation

The rust beta toolchain has a lot of warnings. cargo fix and similars will not fix everything for us so i did it pretty much manually.

Most of the changes are redundant imports, the rest are minor changes too but a lot of them.

Close #8379

Draft until CI runs beta.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Fix all warnings.

Testing

Check CI for beta runs.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Apr 15, 2024
@oxarbitrage oxarbitrage added A-rust Area: Updates to Rust code and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Apr 15, 2024
@arya2 arya2 self-requested a review April 15, 2024 19:33
@oxarbitrage oxarbitrage marked this pull request as ready for review April 15, 2024 20:09
@oxarbitrage oxarbitrage requested review from a team as code owners April 15, 2024 20:09
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team April 15, 2024 20:09
@arya2 arya2 added the do-not-merge Tells Mergify not to merge this PR label Apr 15, 2024
@arya2
Copy link
Contributor

arya2 commented Apr 15, 2024

Added do-not-merge while we tag the release.

@upbqdn I can review this one if you want to prioritize reviewing the release PR and #8383.

upbqdn
upbqdn previously approved these changes Apr 15, 2024
View reviewed changes
zebra-chain/src/tests/vectors.rs Outdated Show resolved Hide resolved
zebra-test/src/mock_service.rs Outdated Show resolved Hide resolved
zebra-chain/src/transparent/address.rs Outdated Show resolved Hide resolved
@upbqdn
Copy link
Member

upbqdn commented Apr 15, 2024

@arya, I'm only noticing your comment now. This was quick to review anyway.

arya2
arya2 previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

zebra-chain/src/transparent/address.rs Outdated Show resolved Hide resolved
zebra-chain/src/transparent/address.rs Outdated Show resolved Hide resolved
zebra-rpc/src/methods/get_block_template_rpcs/types/long_poll.rs Outdated Show resolved Hide resolved
zebra-test/src/mock_service.rs Outdated Show resolved Hide resolved
@oxarbitrage oxarbitrage dismissed stale reviews from arya2 and upbqdn via 221f725 April 15, 2024 21:26
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Apr 15, 2024
@arya2 arya2 removed the do-not-merge Tells Mergify not to merge this PR label Apr 17, 2024
@arya2
Copy link
Contributor

arya2 commented Apr 17, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 887d4a2 into main Apr 18, 2024
135 checks passed
@mergify mergify bot deleted the issue8371 branch April 18, 2024 01:45
@oxarbitrage oxarbitrage mentioned this pull request May 4, 2024
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 left review comments

@upbqdn upbqdn upbqdn approved these changes

Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci(fix): Warnings building in rust beta toolchain
3 participants
@oxarbitrage @arya2 @upbqdn