Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dependabot): Typo in dependabot yaml #8494

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(dependabot): Typo in dependabot yaml #8494

merged 2 commits into from
May 3, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

In #8433 we merged an invalid dependabot yaml.

Solution

Make the yaml valid.

Testing

Make sure fix is valid with https://jsonformatter.org/yaml-validator

Review

Anyone can review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

Should we validate our yamls as part of our CI?

@oxarbitrage oxarbitrage added A-dependencies Area: Dependency file updates P-High 🔥 labels May 3, 2024
@oxarbitrage oxarbitrage self-assigned this May 3, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner May 3, 2024 12:01
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team May 3, 2024 12:01
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label May 3, 2024
@oxarbitrage oxarbitrage mentioned this pull request May 3, 2024
Open
@oxarbitrage oxarbitrage added the A-devops Area: Pipelines, CI/CD and Dockerfiles label May 3, 2024
@oxarbitrage oxarbitrage mentioned this pull request May 3, 2024
Closed
@oxarbitrage
Copy link
Contributor Author

@mpguerra i think we are going to need this one to be admin merged too.

A ticket for disabling or actually run the windows tests for pull requests like this was open at #8496

@upbqdn upbqdn enabled auto-merge (squash) May 3, 2024 12:47
@oxarbitrage oxarbitrage mentioned this pull request May 3, 2024
Closed
@arya2 arya2 changed the title fix(dependabot): Typo in dependbot yaml fix(dependabot): Typo in dependabot yaml May 3, 2024
@mpguerra mpguerra disabled auto-merge May 3, 2024 16:33
@mpguerra mpguerra merged commit 2c5bece into main May 3, 2024
91 checks passed
@mpguerra mpguerra deleted the fix-dependabot-yaml branch May 3, 2024 16:33
@oxarbitrage oxarbitrage mentioned this pull request May 4, 2024
Merged
43 tasks
@mpguerra mpguerra linked an issue May 7, 2024 that may be closed by this pull request
Update dependabot groups to open PRs for ECC dependency updates separately #8431
Closed
@mpguerra mpguerra mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

Assignees

@oxarbitrage oxarbitrage

Labels
A-dependencies Area: Dependency file updates A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Critical 🚑
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dependabot groups to open PRs for ECC dependency updates separately
3 participants
@oxarbitrage @upbqdn @mpguerra