Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: Set NU6 Mainnet activation height and network protocol version #8960

Merged
merged 7 commits into from
Oct 24, 2024
Merged

change: Set NU6 Mainnet activation height and network protocol version #8960

merged 7 commits into from
Oct 24, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Oct 23, 2024 •
edited
Loading

Motivation

Close #8681.

Specifications & References

Solution

  • Set the activation height of NU6 on Mainnet.
  • Update the current network protocol version.

Tests

PR Checklist

  • The PR name is suitable for the changelog.
  • The solution is tested.
  • The PR has a priority label.

@upbqdn upbqdn added A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks P-Medium ⚡ labels Oct 23, 2024
@upbqdn upbqdn self-assigned this Oct 23, 2024
@upbqdn upbqdn requested review from a team as code owners October 23, 2024 12:26
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team October 23, 2024 12:26
@upbqdn upbqdn changed the title change: Set the NU6 Mainnet activation height and network protocol version change: Set NU6 Mainnet activation height and network protocol version Oct 23, 2024
@upbqdn upbqdn marked this pull request as draft October 23, 2024 12:50
@upbqdn upbqdn marked this pull request as ready for review October 24, 2024 11:23
@upbqdn upbqdn requested a review from arya2 October 24, 2024 11:25
arya2
arya2 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning up the test TODOs! Those should be the last of the TODOs introduced during nu6 implementation.

@mergify mergify bot merged commit 0b1562d into main Oct 24, 2024
171 checks passed
@mergify mergify bot deleted the nu6-mainnet-params branch October 24, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/network-reviewers

Assignees

@upbqdn upbqdn

Labels
A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks P-High 🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set the NU6 mainnet activation height and network protocol version
2 participants
@upbqdn @arya2