Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename ZetaBanner to ZetaSystemBanner to match Figma #235

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

thelukewalton
Copy link
Collaborator

fix: remove capitals from issue_tracker url due to issue on pub.dev
fix: Move Zebra head logo into library
fix: Make ZetaAvatar._pixelSize extension private
fix: Badge, button colors updated
fix: Tag, chat item, list item now shrink rather than expands by default
fix: Date and time inputs pass zeta context into their children
feat: Make ZetaDialog public
fix: Changed progress bar, notification list item shapes so they are not affected by contrast

fix: remove capitals from issue_tracker url due to issue on pub.dev
fix: Move Zebra head logo into library
fix: Make ZetaAvatar._pixelSize extension private
fix: Badge, button colors updated
fix: Tag, chat item, list item  now shrink rather than expands by default
fix: Date and time inputs pass zeta context into their children
feat: Make ZetaDialog public
fix: Changed progress bar, notification list item shapes so they are not affected by contrast
@thelukewalton thelukewalton requested a review from a team as a code owner January 9, 2025 20:04
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR Checks complete

  • ✅ - Linting / Formatting
  • ✅ - Static analysis passed
  • ✅ - All tests passed
  • ✅ - Branch is not behind
  • 📈 - Code coverage: 52.46% (🔻 down from 52.54%)
    See details
    File Name%Passing?
    lib/generated/tokens/primitives.g.dart67.6%⛔️
    lib/generated/tokens/semantics.g.dart89.9%
    lib/src/components/accordion/accordion.dart100%
    lib/src/utils/rounded.dart100%
    lib/src/components/avatar_rail/avatar_rail.dart53.7%⛔️
    lib/src/components/avatars/avatar.dart94.5%
    lib/src/components/badges/indicator.dart100%
    lib/src/components/badges/label.dart100%
    lib/src/components/badges/priority_pill.dart100%
    lib/src/components/badges/status_label.dart100%
    lib/src/components/badges/tag.dart98.5%
    lib/src/components/bottom sheets/bottom_sheet.dart0%⛔️
    lib/src/components/bottom sheets/menu_items.dart0%⛔️
    lib/src/components/breadcrumb/breadcrumb.dart86.5%
    lib/src/components/button_group/button_group.dart0%⛔️
    lib/src/components/buttons/button.dart97.7%
    lib/src/components/buttons/button_style.dart100%
    lib/src/components/buttons/icon_button.dart51.2%⛔️
    lib/src/components/buttons/input_icon_button.dart72.7%⛔️
    lib/src/components/chat_item/chat_item.dart98.6%
    lib/src/components/checkbox/checkbox.dart100%
    lib/src/components/chips/assist_chip.dart0%⛔️
    lib/src/components/chips/chip.dart81.6%
    lib/src/components/chips/filter_chip.dart0%⛔️
    lib/src/components/chips/input_chip.dart0%⛔️
    lib/src/components/chips/status_chip.dart90.9%
    lib/src/components/comms_button/comms_button.dart82%
    lib/src/components/contact_item/contact_item.dart0%⛔️
    lib/src/components/date_input/date_input.dart0%⛔️
    lib/src/components/dial_pad/dial_pad.dart100%
    lib/src/components/dialog/dialog.dart0%⛔️
    lib/src/components/dropdown/dropdown.dart0%⛔️
    lib/src/components/fabs/fab.dart100%
    lib/src/components/filter_selection/filter_selection.dart0%⛔️
    lib/src/components/global_header/global_header.dart0%⛔️
    lib/src/components/global_header/header_tab_item.dart0%⛔️
    lib/src/components/icon/icon.dart100%
    lib/src/components/in_page_banner/in_page_banner.dart100%
    lib/src/components/list_item/dropdown_list_item.dart0%⛔️
    lib/src/components/list_item/list_item.dart0%⛔️
    lib/src/components/list_item/notification_list_item.dart0%⛔️
    lib/src/components/navigation bar/navigation_bar.dart94.5%
    lib/src/components/navigation_rail/navigation_rail.dart0%⛔️
    lib/src/components/pagination/pagination.dart0.6%⛔️
    lib/src/components/password/password_input.dart100%
    lib/src/components/phone_input/phone_input.dart0%⛔️
    lib/src/components/progress/progress_bar.dart0%⛔️
    lib/src/components/progress/progress_circle.dart0%⛔️
    lib/src/components/radio/radio.dart0%⛔️
    lib/src/components/range_selector/range_selector.dart84.5%
    lib/src/components/screen_header_bar/screen_header_bar.dart0%⛔️
    lib/src/components/search_bar/search_bar.dart98.1%
    lib/src/components/segmented_control/segmented_control.dart0%⛔️
    lib/src/components/select_input/select_input.dart0%⛔️
    lib/src/components/slider/slider.dart82.3%
    lib/src/components/snack_bar/snack_bar.dart0%⛔️
    lib/src/components/stepper/stepper.dart95.1%
    lib/src/components/stepper_input/stepper_input.dart71.9%⛔️
    lib/src/components/switch/zeta_switch.dart0%⛔️
    lib/src/components/system_banner/system_banner.dart85.4%
    lib/src/components/tabs/tab.dart0%⛔️
    lib/src/components/tabs/tab_bar.dart0%⛔️
    lib/src/components/text_input/text_input.dart0%⛔️
    lib/src/components/time_input/time_input.dart0%⛔️
    lib/src/components/tooltip/tooltip.dart98.9%
    lib/src/components/top_app_bar/top_app_bar.dart86%
    lib/src/interfaces/form_field.dart81.4%
    lib/src/components/text_input/internal_text_input.dart72.5%⛔️
    lib/src/components/list_item/list_scope.dart0%⛔️
    lib/src/components/phone_input/countries.dart10%⛔️
    lib/src/components/progress/progress.dart0%⛔️
    lib/src/components/switch/material_switch.dart0%⛔️
    lib/src/components/text_input/hint_text.dart77.8%⛔️
    lib/src/components/text_input/input_label.dart0%⛔️
    lib/src/components/top_app_bar/extended_top_app_bar.dart93.9%
    lib/src/components/top_app_bar/search_top_app_bar.dart88%
    lib/src/theme/breakpoints.dart81.8%
    lib/src/theme/color_extensions.dart86.1%
    lib/src/theme/color_swatch.dart72%⛔️
    lib/src/theme/contrast.dart50%⛔️
    lib/src/theme/custom_theme.dart55.6%⛔️
    lib/src/theme/theme_service.dart18.5%⛔️
    lib/src/theme/tokens.dart50%⛔️
    lib/src/utils/debounce.dart100%
    lib/src/utils/extensions.dart100%
    lib/src/utils/enums.dart90%
    lib/src/utils/nothing.dart100%
    lib/src/utils/platform/platform_is.dart0%⛔️
    lib/src/utils/platform/universal_platform_vm.dart7.1%⛔️
    lib/src/utils/zeta.dart100%
    lib/src/utils/zeta_provider.dart100%

Created with Flutter code quality action

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 97697f7):

https://zeta-flutter-main--pr-235-bugs090125-cc38aljz.web.app

(expires Fri, 17 Jan 2025 10:33:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6

@thelukewalton thelukewalton merged commit 74fee17 into develop Jan 10, 2025
4 checks passed
@thelukewalton thelukewalton deleted the bugs090125 branch January 10, 2025 10:58
thelukewalton added a commit that referenced this pull request Feb 4, 2025
fix: remove capitals from issue_tracker url due to issue on pub.dev
fix: Move Zebra head logo into library
fix: Make ZetaAvatar._pixelSize extension private
fix: Badge, button colors updated
fix: Tag, chat item, list item  now shrink rather than expands by default
fix: Date and time inputs pass zeta context into their children
feat: Make ZetaDialog public
fix: Changed progress bar, notification list item shapes so they are not affected by contrast
test: Update in page banner tests as banner no longer fully expands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants