Fix remaining Ruff lints and (most) type errors #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
chore/more-linting
branch
from
325037c
to
a23d971
Compare
Nerixyz
force-pushed
the
chore/more-linting
branch
from
a23d971
to
87a563c
Compare
ZedThree
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this fixes the remaining lints from #133 (that's the target of the PR) as well as some typing errors (the remaining ones can be fixed in a separate PR). I noticed that
pygithubnow hasPullRequest.get_commentswhich we could migrate to. Furthermore, there should probably a ruff check in CI.Aside: A release would be great. Currently, comments are duplicated (not culled) - this is fixed on master (I think).