-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site: GetUserIP() returns an IPv4 if present #1363
base: master
Are you sure you want to change the base?
Conversation
Fixes a failure with site ban by IP
This returns IP address of the server instead of the IP address of the person who made the request. You are resolving empty string. |
Is there a way to access |
ForumController has "Request" object in it, so it can extract data from it. This function could be written in some other place and take Request as an input parameter instead. |
I'm still not sure about this thing. Running DNS resolve will slow down the site a lot. |
I think if it only checked ipv6 and not all it should be fine.. |
8e07aab
to
9d6ea62
Compare
5225232
to
6f75389
Compare
ce1528b
to
242f4d7
Compare
f3c5f37
to
5d70725
Compare
This fixes a potential failure with site ban by IP, where it currently gets the IPv6 and tries to look for matching IPv4 bans.
(Alternatively lobby clients could be allowed to report IPv6 instead)