Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payments: Update getPayments call to limit the number of payments #2614

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Payments: Update getPayments call to limit the number of payments #2614

wants to merge 5 commits into from
+42 −11

Conversation

shubhamkmr04
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 commented Dec 10, 2024 •
edited
Loading

Issue: #2605

@kaloudis kaloudis linked an issue Dec 10, 2024 that may be closed by this pull request
paying an invoices puts my server at highload and makes it crash #2605
Open
@kaloudis kaloudis added this to the v0.9.4 milestone Dec 10, 2024
@kaloudis kaloudis added Bug Something isn't working Payments labels Dec 10, 2024
@shubhamkmr04 shubhamkmr04 marked this pull request as draft December 10, 2024 17:46
@shubhamkmr04 shubhamkmr04 force-pushed the shubham/limit-fetching-payment branch from a29967e to cda7164 Compare December 11, 2024 14:02
@shubhamkmr04 shubhamkmr04 force-pushed the shubham/limit-fetching-payment branch from cda7164 to 0f9db4f Compare December 11, 2024 14:06
@shubhamkmr04 shubhamkmr04 force-pushed the shubham/limit-fetching-payment branch from 8141c48 to 00f7bac Compare December 11, 2024 16:04
kaloudis
kaloudis reviewed Dec 11, 2024
View reviewed changes
stores/PaymentsStore.ts Outdated Show resolved Hide resolved
@shubhamkmr04 shubhamkmr04 force-pushed the shubham/limit-fetching-payment branch 2 times, most recently from 8b2bc1b to 6bc25bb Compare December 12, 2024 15:18
kaloudis
kaloudis requested changes Dec 14, 2024
View reviewed changes
stores/PaymentsStore.ts Outdated Show resolved Hide resolved
@shubhamkmr04 shubhamkmr04 force-pushed the shubham/limit-fetching-payment branch from 19df626 to d922eb5 Compare December 14, 2024 06:09
@kaloudis
Copy link
Contributor

@shubhamkmr04 did you want to make any more changes here or is this ready for testing and review?

@shubhamkmr04
Copy link
Contributor Author

@shubhamkmr04 did you want to make any more changes here or is this ready for testing and review?

Its good to go i think

@shubhamkmr04 shubhamkmr04 marked this pull request as ready for review December 15, 2024 06:19
kaloudis
kaloudis requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Everything looks good but we need to change backends/EmbeddedLND as well

@shubhamkmr04 shubhamkmr04 force-pushed the shubham/limit-fetching-payment branch 2 times, most recently from c132e13 to ba54811 Compare December 17, 2024 16:23
@shubhamkmr04 shubhamkmr04 force-pushed the shubham/limit-fetching-payment branch from ba54811 to bba70b5 Compare December 17, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaloudis kaloudis kaloudis requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug Something isn't working Payments
Projects
None yet
Milestone
v0.9.4
Development

Successfully merging this pull request may close these issues.

paying an invoices puts my server at highload and makes it crash
2 participants
@shubhamkmr04 @kaloudis